Skip to content

PassNode: Fix depthTexture creation when depthBuffer: false #33239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thelazylamaGit wants to merge 3 commits into
base: dev
Choose a base branch
from
+40 −21
Open

PassNode: Fix depthTexture creation when depthBuffer: false #33239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7396411
PassNode: make depthTexture optional
thelazylamaGit Mar 25, 2026
92cfd28
Textures: prevent always creating depth texture
thelazylamaGit Mar 25, 2026
4d7c0bc
PassNode: Fix scope check
thelazylamaGit Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions src/nodes/display/PassNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,14 +251,22 @@ class PassNode extends TempNode {
*/
this._height = 1;

const depthTexture = new DepthTexture();
depthTexture.isRenderTargetTexture = true;
//depthTexture.type = FloatType;
depthTexture.name = 'depth';

const renderTarget = new RenderTarget( this._width * this._pixelRatio, this._height * this._pixelRatio, { type: HalfFloatType, ...options, } );
renderTarget.texture.name = 'output';
renderTarget.depthTexture = depthTexture;

let depthTexture = null;

if ( this.scope === PassNode.DEPTH || options.depthBuffer !== false ) {

depthTexture = new DepthTexture();
depthTexture.isRenderTargetTexture = true;
//depthTexture.type = FloatType;
depthTexture.name = 'depth';

renderTarget.depthTexture = depthTexture;

}


/**
* The pass's render target.
Expand Down Expand Up @@ -310,13 +318,18 @@ class PassNode extends TempNode {
* A dictionary holding the internal result textures.
*
* @private
* @type {Object<string, Texture>}
* @type {{ output: Texture, depth?: DepthTexture }}
*/
this._textures = {
output: renderTarget.texture,
depth: depthTexture
output: renderTarget.texture
};

if ( depthTexture !== null ) {

this._textures.depth = depthTexture;

}

/**
* A dictionary holding the internal texture nodes.
*
Expand Down Expand Up @@ -757,7 +770,7 @@ class PassNode extends TempNode {

this.renderTarget.texture.type = renderer.getOutputBufferType();

if ( renderer.reversedDepthBuffer === true ) {
if ( renderer.reversedDepthBuffer === true && this.renderTarget.depthTexture !== null ) {

this.renderTarget.depthTexture.type = FloatType;

Expand Down
28 changes: 17 additions & 11 deletions src/renderers/common/Textures.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,24 +71,30 @@ class Textures extends DataMap {
const mipWidth = size.width >> activeMipmapLevel;
const mipHeight = size.height >> activeMipmapLevel;

let depthTexture = renderTarget.depthTexture || depthTextureMips[ activeMipmapLevel ];
const useDepthTexture = renderTarget.depthBuffer === true || renderTarget.stencilBuffer === true;
let depthTexture = null;

let textureNeedsUpdate = false;

if ( depthTexture === undefined && useDepthTexture ) {
if ( useDepthTexture ) {

depthTexture = new DepthTexture();
depthTexture = renderTarget.depthTexture || depthTextureMips[ activeMipmapLevel ];

depthTexture.format = renderTarget.stencilBuffer ? DepthStencilFormat : DepthFormat;
depthTexture.type = renderTarget.stencilBuffer ? UnsignedInt248Type : UnsignedIntType; // FloatType
depthTexture.image.width = mipWidth;
depthTexture.image.height = mipHeight;
depthTexture.image.depth = size.depth;
depthTexture.renderTarget = renderTarget;
depthTexture.isArrayTexture = renderTarget.multiview === true && size.depth > 1;
if ( depthTexture === undefined ) {

depthTextureMips[ activeMipmapLevel ] = depthTexture;
depthTexture = new DepthTexture();

depthTexture.format = renderTarget.stencilBuffer ? DepthStencilFormat : DepthFormat;
depthTexture.type = renderTarget.stencilBuffer ? UnsignedInt248Type : UnsignedIntType; // FloatType
depthTexture.image.width = mipWidth;
depthTexture.image.height = mipHeight;
depthTexture.image.depth = size.depth;
depthTexture.renderTarget = renderTarget;
depthTexture.isArrayTexture = renderTarget.multiview === true && size.depth > 1;

depthTextureMips[ activeMipmapLevel ] = depthTexture;

}

}

Expand Down
Loading