-
Notifications
You must be signed in to change notification settings - Fork 469
Add support for speculative contacts #2366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nvtw
wants to merge
89
commits into
newton-physics:main
Choose a base branch
from
nvtw:dev/tw2/speculative_contacts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 86 commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
749b0e0
First attempt to bring support for speculative contacts into the coll…
nvtw 41ca9d7
Add more unit tests for speculative contacts
nvtw 8881183
Ran ruff
nvtw 8f6dd7b
Merge branch 'main' into dev/tw2/speculative_contacts
nvtw fed33dc
Merge branch 'main' into dev/tw2/speculative_contacts
nvtw de66f90
Implement MR comments
nvtw 223a5b4
Merge branch 'main' into dev/tw2/speculative_contacts
nvtw 2e8bf6b
Update the docs
nvtw 5e3aece
Merge branch 'main' into dev/tw2/speculative_contacts
nvtw 0907140
Improve the docs
nvtw 89cbdf6
Merge branch 'main' into dev/tw2/speculative_contacts
nvtw 5113899
Extend speculative contacts to support meshes
nvtw 3e19e78
Deterministic contacts start to work for convex vs convex and convex …
nvtw e67a7a9
Determinism starts to work for meshes
nvtw f2d7647
Fix issues in contact pre-pruning
nvtw 73849b1
Add more unit tests
nvtw 50858c7
Ran ruff
nvtw ad5c0f7
Remove debug printf that slipped in
nvtw 7623a82
Forgot to add new file
nvtw 4f15e42
Ran ruff
nvtw f9ef6c4
Update the docs
nvtw c38b83e
Fix sort issue in contact determinism
nvtw 92d9399
Fix hte docs
nvtw 587be69
Fix the performance regression
nvtw ed6ee76
Implement more improvements
nvtw 41ed6c8
Implement CodeRabbit comments
nvtw d2f7a09
Update the changelog and the docs
nvtw c7bc73c
Implement MR comments
nvtw 5df8e2c
Merge branch 'main' into dev/tw3/deterministic_contacts
nvtw 5e89322
Merge branch 'main' into dev/tw3/deterministic_contacts
nvtw ac66d07
Implement more MR comments
nvtw 4d56f4f
Merge branch 'main' into dev/tw3/deterministic_contacts
nvtw 45cfbf0
Implement more CodeRabbit comments
nvtw 77b5331
Improve sorting
nvtw bb3ec2a
Improve the unit tests
nvtw c37a749
Attempt to fix some remaining non-determinism
nvtw f5f78e4
First attempt towards contact matching
nvtw a367f23
Reduce memory footprint
nvtw f6c61eb
Bugfix
nvtw 975d973
Improve the test coverage
nvtw 77882a0
Add more diagnostics to the tests.
nvtw 3a8ed92
Disable prepruning for determinism experiments.
nvtw c639770
Attempt to fix CI
nvtw a0b1462
Remove unnecessary file
nvtw d10983c
Merge remote-tracking branch 'origin/dev/tw3/deterministic_contacts' …
nvtw 1a5b370
Merge branch 'main' into dev/tw3/deterministic_contacts
nvtw 94eef59
Merge remote-tracking branch 'refs/remotes/origin/dev/tw3/determinist…
nvtw 3e833e9
Merge branch 'main' into dev/tw3/contact_matching
nvtw 1370429
Update the changelog
nvtw ed4c6e1
Update the documentation
nvtw b531b49
Implement CodeRabbit comments
nvtw a0073fc
Merge branch 'main' into dev/tw3/contact_matching
nvtw 8751e22
Merge branch 'main' into dev/tw2/speculative_contacts
nvtw 69d3491
Ran ruff
nvtw a76d50f
Merge branch 'main' into dev/tw2/speculative_contacts
nvtw b739859
Implement CodeRabbit comments
nvtw e994d6b
Implement MR comments
nvtw 631b7a3
Merge branch 'main' into dev/tw3/contact_matching
nvtw 2c33eee
Implement CodeRabbit comments
nvtw cb52409
Implement more MR comments
nvtw 1fc6ea7
Update docs
nvtw 4379204
Fix CI
nvtw 1295271
Merge branch 'main' into dev/tw3/contact_matching
nvtw 6691056
Test better matching - not done yet
nvtw d8f89c7
Ensure that only one contact can claim a contact from the last frame
nvtw 2c82a1d
Small performance improvement
nvtw 287ce43
Merge branch 'main' into dev/tw3/contact_matching
nvtw cf4e985
Add sticky contact matching mode
nvtw 99b0e2c
Merge branch 'main' into dev/tw3/contact_matching
nvtw bd6ed7a
Handle contact matching break distance evaluation in a more symmetric…
nvtw f1dca6e
Improve the docs
nvtw 4fec7f5
Attempt to fix CI docs
nvtw dcd693b
Merge branch 'main' into dev/tw3/contact_matching
nvtw bfb4dc3
Contact matching experiments
nvtw ac5c049
Add more diagnostic output
nvtw 49ce8bd
Revert "Add more diagnostic output"
nvtw 743bac9
Revert "Contact matching experiments"
nvtw 011d75c
Fix normal misalignment issue
nvtw e6f0542
Unit test fixes
nvtw f47d3a0
Merge branch 'main' into dev/tw3/contact_matching
nvtw e33ca55
Fix too long changelog entry and mark sticky mode as experimental
nvtw dbe98ef
Merge branch 'main' into dev/tw3/contact_matching
nvtw c05201f
Remove superfluous enum
nvtw 690bf2c
Implement more MR comments
nvtw 49712a0
Merge branch 'main' into dev/tw3/contact_matching
nvtw 3c67048
Merge branch 'dev/tw3/contact_matching' into dev/tw2/speculative_cont…
nvtw 1ae123a
Merge branch 'main' into dev/tw2/speculative_contacts
nvtw 32e0bff
Implement the MR comments
nvtw 312d9a1
Attempt to fix CI
nvtw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,6 +57,7 @@ newton | |
| ParticleFlags | ||
| SDF | ||
| ShapeFlags | ||
| SpeculativeContactConfig | ||
| State | ||
| TetMesh | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.