-
Notifications
You must be signed in to change notification settings - Fork 463
Add Newton course notebook, improve ViewerViser #2415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
eric-heiden
wants to merge
15
commits into
newton-physics:main
Choose a base branch
from
eric-heiden:course-notebook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e0a8df6
Initial check-in of the GTC course notebook
eric-heiden c179d55
Clean up, add license header
eric-heiden ebde0db
Improve tutorial notebook
eric-heiden 546e290
Add changelog entry for introductory tutorial notebook
eric-heiden e21cbf0
Include viser in "notebook" dependency group
eric-heiden 9d66a49
Add jupyter server proxy dependency
eric-heiden fc8655c
Fix URL handling in ViewerViser
eric-heiden 2179054
Fix code formatting
eric-heiden c067369
Update viser, load client HTML directly from viser dependency
eric-heiden d98269f
Use installed Viser client for notebooks
eric-heiden 8dbed2f
Update year in tutorial notebook
eric-heiden 0ff4bdc
Render planes as wireframe in ViewerViser
eric-heiden fe8ed7a
Remove break.jpg
eric-heiden e7a5a35
Merge branch 'main' of github.com:newton-physics/newton into course-n…
eric-heiden a5486a6
Fix changelog
eric-heiden File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the same
staticfallback used byViewerViser.newton/_src/viewer/viewer_viser.pychecks bothclient/buildandstatic, but this docs-side copy path only registersclient/build. If the installedviserpackage exposes the fallback layout, Sphinx will quietly skip copying the player assets and the embedded notebook replays will end up with a broken../_static/viser/index.html.♻️ Proposed fix
try: import inspect # noqa: PLC0415 import viser # noqa: PLC0415 - src_candidates.append(Path(inspect.getfile(viser)).resolve().parent / "client" / "build") + viser_package_dir = Path(inspect.getfile(viser)).resolve().parent + src_candidates.extend( + [ + viser_package_dir / "client" / "build", + viser_package_dir / "static", + ] + ) except Exception: pass🤖 Prompt for AI Agents