Skip to content

fix(upload): skip locked files during upload to avoid errors #9810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgallien wants to merge 5 commits into
base: master
Choose a base branch
from

chore: only ignore locked files when uploading them

8390b7d
Select commit
Loading
Failed to load commit list.
Open

fix(upload): skip locked files during upload to avoid errors #9810

chore: only ignore locked files when uploading them
8390b7d
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 23, 2026 in 36m 48s

Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 80%)
1 New Bugs (required ≤ 0)
146 New Code Smells (required ≤ 0)
E Reliability Rating on New Code (required ≥ A)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 277 in src/csync/csync_exclude.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid this unnecessary copy by using a "const" reference. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ1uNDb1s0Fbzs2jIOw4&open=AZ1uNDb1s0Fbzs2jIOw4&pullRequest=9810

Check warning on line 429 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce this switch case number of lines from 6 to at most 5, for example by extracting code into methods. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2a_tmiy8hqXC4KhsjN&open=AZ2a_tmiy8hqXC4KhsjN&pullRequest=9810

Check warning on line 630 in src/gui/folder.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'qsizetype' (aka 'long long') to 'int' 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2a_tiTy8hqXC4Khsic&open=AZ2a_tiTy8hqXC4Khsic&pullRequest=9810

Check warning on line 1035 in src/libsync/syncengine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "cancel" of type "_Bool" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2bDsGt1W-EvMDtBFr4&open=AZ2bDsGt1W-EvMDtBFr4&pullRequest=9810

Check failure on line 102 in src/libsync/propagateuploadng.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2bDsNo1W-EvMDtBFsN&open=AZ2bDsNo1W-EvMDtBFsN&pullRequest=9810

Check warning on line 660 in src/gui/folder.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "pinState" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2a_tiTy8hqXC4Khsii&open=AZ2a_tiTy8hqXC4Khsii&pullRequest=9810

Check warning on line 2487 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the redundant return type of this lambda. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2a_tmiy8hqXC4Khsjx&open=AZ2a_tmiy8hqXC4Khsjx&pullRequest=9810

Check failure on line 697 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture all local variables required in this lambda. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2a_tmiy8hqXC4KhsjQ&open=AZ2a_tmiy8hqXC4KhsjQ&pullRequest=9810

Check failure on line 1698 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2a_tmiy8hqXC4Khsje&open=AZ2a_tmiy8hqXC4Khsje&pullRequest=9810

Check warning on line 1180 in src/libsync/syncengine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "filesDeletedThresholdExceeded" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2bDsGt1W-EvMDtBFr6&open=AZ2bDsGt1W-EvMDtBFr6&pullRequest=9810

Check warning on line 477 in src/libsync/syncengine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::lower_bound" that takes a range. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2bDsGt1W-EvMDtBFrw&open=AZ2bDsGt1W-EvMDtBFrw&pullRequest=9810

Check warning on line 299 in src/libsync/discoveryphase.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2bDsJK1W-EvMDtBFsM&open=AZ2bDsJK1W-EvMDtBFsM&pullRequest=9810

Check failure on line 1597 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2a_tmiy8hqXC4KhsjX&open=AZ2a_tmiy8hqXC4KhsjX&pullRequest=9810

Check warning on line 573 in src/gui/folder.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "result" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2a_tiTy8hqXC4Khsih&open=AZ2a_tiTy8hqXC4Khsih&pullRequest=9810

Check warning on line 32 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2a_tmiy8hqXC4KhsjA&open=AZ2a_tmiy8hqXC4KhsjA&pullRequest=9810

Check warning on line 254 in src/gui/folder.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "isEmpty()" to check whether the container is empty or not. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2a_tiTy8hqXC4Khsie&open=AZ2a_tiTy8hqXC4Khsie&pullRequest=9810

Check failure on line 386 in src/libsync/syncengine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2bDsGt1W-EvMDtBFru&open=AZ2bDsGt1W-EvMDtBFru&pullRequest=9810

Check warning on line 111 in src/csync/csync_exclude.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2fvUKbgW1aIMTDWlLr&open=AZ2fvUKbgW1aIMTDWlLr&pullRequest=9810

Check failure on line 87 in src/csync/csync_exclude.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 27 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ1uNDb1s0Fbzs2jIOwz&open=AZ1uNDb1s0Fbzs2jIOwz&pullRequest=9810

Check warning on line 349 in src/libsync/discoveryphase.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2bDsJK1W-EvMDtBFsL&open=AZ2bDsJK1W-EvMDtBFsL&pullRequest=9810

Check warning on line 235 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "willBeExcluded" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2a_tmiy8hqXC4KhsjE&open=AZ2a_tmiy8hqXC4KhsjE&pullRequest=9810

Check warning on line 1338 in src/libsync/syncengine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2bDsGt1W-EvMDtBFsF&open=AZ2bDsGt1W-EvMDtBFsF&pullRequest=9810

Check warning on line 1637 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this declaration by a structured binding declaration. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2a_tmiy8hqXC4Khsjc&open=AZ2a_tmiy8hqXC4Khsjc&pullRequest=9810

Check warning on line 1141 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "dirItemDbRecord" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2a_tmiy8hqXC4KhsjV&open=AZ2a_tmiy8hqXC4KhsjV&pullRequest=9810

Check warning on line 956 in src/gui/folder.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::none_of" that takes a range. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ2a_tiTy8hqXC4Khsir&open=AZ2a_tiTy8hqXC4Khsir&pullRequest=9810
View more details on SonarQubeCloud