Add #[\NoDiscard] to result-oriented DBAL APIs#328
Merged
Conversation
Closed
Agent-Logs-Url: https://github.com/nextras/dbal/sessions/05046898-4e07-4b53-91cf-3c4a037b94a7 Co-authored-by: hrach <284263+hrach@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add NoDiscard attribute to relevant API locations
Add Apr 13, 2026
#[\NoDiscard] to result-oriented DBAL APIs
hrach
requested changes
Apr 13, 2026
Agent-Logs-Url: https://github.com/nextras/dbal/sessions/ca1d7294-6f6f-459d-be6f-4d7b8ff148f1 Co-authored-by: hrach <284263+hrach@users.noreply.github.com>
hrach
approved these changes
Apr 14, 2026
…osures Agent-Logs-Url: https://github.com/nextras/dbal/sessions/6a0b1d49-81e5-416c-b5b6-977208455edb Co-authored-by: hrach <284263+hrach@users.noreply.github.com>
hrach
approved these changes
Apr 14, 2026
hrach
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#[\\NoDiscard]emitsE_USER_WARNINGbefore function executes, Nette Tester converts it to a wrong-type exception insideAssert::exception/Assert::throwsclosures$_ =inResultTest.phptforfetchField()andfetchPairs()call sites inside exception-testing closures$_ =inresult.buffering.phptforfetchPairs()call site inside exception-testing closure$_ =inconnection.postgres.phptforgetLastInsertedId()call site inside exception-testing closure