Add #[\NoDiscard] to result-oriented DBAL APIs

src/Connection.php

@@ -93,13 +93,15 @@ public function reconnectWithConfig(array $config): void
 	}
 
 
+	#[\NoDiscard]
 	public function getDriver(): IDriver
 	{
 		return $this->driver;
 	}
 
 
 	/** @inheritdoc */
+	#[\NoDiscard]
 	public function getConfig(): array
 	{
 		return $this->config;
@@ -144,6 +146,7 @@ public function queryByQueryBuilder(QueryBuilder $queryBuilder): Result
 
 
 	/** @inheritdoc */
+	#[\NoDiscard]
 	public function getLastInsertedId(string|Fqn|null $sequenceName = null)
 	{
 		if (!$this->connected) {
@@ -154,6 +157,7 @@ public function getLastInsertedId(string|Fqn|null $sequenceName = null)
 
 
 	/** @inheritdoc */
+	#[\NoDiscard]
 	public function getAffectedRows(): int
 	{
 		if (!$this->connected) {
@@ -164,6 +168,7 @@ public function getAffectedRows(): int
 
 
 	/** @inheritdoc */
+	#[\NoDiscard]
 	public function getPlatform(): IPlatform
 	{
 		if ($this->platform === null) {
@@ -175,6 +180,7 @@ public function getPlatform(): IPlatform
 
 
 	/** @inheritdoc */
+	#[\NoDiscard]
 	public function createQueryBuilder(): QueryBuilder
 	{
 		return new QueryBuilder($this->getPlatform());
@@ -254,6 +260,7 @@ public function rollbackTransaction(): void
 
 
 	/** @inheritdoc */
+	#[\NoDiscard]
 	public function getTransactionNestedIndex(): int
 	{
 		return $this->nestedTransactionIndex;

src/IConnection.php

@@ -50,13 +50,15 @@ public function reconnect(): void;
 	public function reconnectWithConfig(array $config): void;
 
 
+	#[\NoDiscard]
 	public function getDriver(): IDriver;
 
 
 	/**
 	 * Returns connection configuration.
 	 * @return array<string, mixed>
 	 */
+	#[\NoDiscard]
 	public function getConfig(): array;
 
 
@@ -103,18 +105,22 @@ public function queryByQueryBuilder(QueryBuilder $queryBuilder): Result;
 	 *
 	 * @return int|string|null
 	 */
+	#[\NoDiscard]
 	public function getLastInsertedId(string|Fqn|null $sequenceName = null);
 
 
 	/**
 	 * Returns number of affected rows.
 	 */
+	#[\NoDiscard]
 	public function getAffectedRows(): int;
 
 
+	#[\NoDiscard]
 	public function getPlatform(): IPlatform;
 
 
+	#[\NoDiscard]
 	public function createQueryBuilder(): QueryBuilder;
 
 
@@ -158,6 +164,7 @@ public function rollbackTransaction(): void;
 	 * 1 = basic transaction
 	 * >1 = nested transaction through save-points
 	 */
+	#[\NoDiscard]
 	public function getTransactionNestedIndex(): int;
 
 

src/Platforms/Data/Fqn.php

@@ -22,6 +22,7 @@ public function __construct(
 	}
 
 
+	#[\NoDiscard]
 	public function getUnescaped(): string
 	{
 		if ($this->schema === '') {

src/Platforms/IPlatform.php

@@ -22,6 +22,7 @@ interface IPlatform
 	/**
 	 * Returns platform name.
 	 */
+	#[\NoDiscard]
 	public function getName(): string;
 
 
@@ -30,33 +31,38 @@ public function getName(): string;
 	 * If no schema is provided, it uses the current schema name (search path).
 	 * @return array<string, Table>
 	 */
+	#[\NoDiscard]
 	public function getTables(?string $schema = null): array;
 
 
 	/**
 	 * Returns list of table columns metadata, indexed by column name.
 	 * @return array<string, Column>
 	 */
+	#[\NoDiscard]
 	public function getColumns(string $table, ?string $schema = null): array;
 
 
 	/**
 	 * Returns list of table foreign keys, indexed by column name.
 	 * @return array<string, ForeignKey>
 	 */
+	#[\NoDiscard]
 	public function getForeignKeys(string $table, ?string $schema = null): array;
 
 
 	/**
 	 * Returns primary sequence name for the table.
 	 * If not supported nor present, returns a null.
 	 */
+	#[\NoDiscard]
 	public function getPrimarySequenceName(string $table, ?string $schema = null): ?string;
 
 
 	/**
 	 * Formats string value to SQL string.
 	 */
+	#[\NoDiscard]
 	public function formatString(string $value): string;
 
 
@@ -65,67 +71,78 @@ public function formatString(string $value): string;
 	 * @param int $mode -1 = left, 0 = both, 1 = right
 	 * @return mixed
 	 */
+	#[\NoDiscard]
 	public function formatStringLike(string $value, int $mode);
 
 
 	/**
 	 * Formats Json value to SQL string.
 	 */
+	#[\NoDiscard]
 	public function formatJson(mixed $value): string;
 
 
 	/**
 	 * Formats boolean to SQL string.
 	 */
+	#[\NoDiscard]
 	public function formatBool(bool $value): string;
 
 
 	/**
 	 * Formats column or dot separated identifier to SQL string.
 	 */
+	#[\NoDiscard]
 	public function formatIdentifier(string $value): string;
 
 
 	/**
 	 * Formats time-zone aware DateTimeInterface instance to SQL string.
 	 */
+	#[\NoDiscard]
 	public function formatDateTime(DateTimeInterface $value): string;
 
 
 	/**
 	 * Formats local DateTimeInterface instance to SQL string.
 	 */
+	#[\NoDiscard]
 	public function formatLocalDateTime(DateTimeInterface $value): string;
 
 
 	/**
 	 * Formats local date from DateTimeInterface instance to SQL string.
 	 */
+	#[\NoDiscard]
 	public function formatLocalDate(DateTimeInterface $value): string;
 
 
 	/**
 	 * Formats DateInterval to SQL string.
 	 */
+	#[\NoDiscard]
 	public function formatDateInterval(DateInterval $value): string;
 
 
 	/**
 	 * Formats blob value to SQL string.
 	 */
+	#[\NoDiscard]
 	public function formatBlob(string $value): string;
 
 
 	/**
 	 * Formats LIMIT & OFFSET values to SQL string.
 	 */
+	#[\NoDiscard]
 	public function formatLimitOffset(?int $limit, ?int $offset): string;
 
 
 	/**
 	 * Returns SQL file parser
 	 * !!!This function requires nextras/multi-query-parser dependency!!!
 	 */
+	#[\NoDiscard]
 	public function createMultiQueryParser(): IMultiQueryParser;
 
 

src/Result/Result.php

@@ -59,6 +59,7 @@ public function unbuffered(): Result
 	}
 
 
+	#[\NoDiscard]
 	public function getAdapter(): IResultAdapter
 	{
 		return $this->adapter;
@@ -111,6 +112,7 @@ private function normalize(array &$data): void
 	/**
 	 * @return mixed|null
 	 */
+	#[\NoDiscard]
 	public function fetchField(int $column = 0)
 	{
 		if (($row = $this->fetch()) !== null) { // = intentionally
@@ -124,6 +126,7 @@ public function fetchField(int $column = 0)
 	/**
 	 * @return Row[]
 	 */
+	#[\NoDiscard]
 	public function fetchAll(): array
 	{
 		return iterator_to_array($this);
@@ -133,6 +136,7 @@ public function fetchAll(): array
 	/**
 	 * @return array<mixed>
 	 */
+	#[\NoDiscard]
 	public function fetchPairs(?string $key = null, ?string $value = null): array
 	{
 		if ($key === null && $value === null) {
@@ -164,6 +168,7 @@ public function fetchPairs(?string $key = null, ?string $value = null): array
 	 * Returns list of column names in result.
 	 * @return list<string>
 	 */
+	#[\NoDiscard]
 	public function getColumns(): array
 	{
 		return array_map(

src/Result/Row.php

@@ -23,6 +23,7 @@ public function __construct(array $data)
 	/**
 	 * @return array<string, mixed>
 	 */
+	#[\NoDiscard]
 	public function toArray(): array
 	{
 		return (array) $this;
@@ -36,6 +37,7 @@ public function __get(string $name): mixed
 	}
 
 
+	#[\NoDiscard]
 	public function getNthField(int $offset): mixed
 	{
 		$slice = array_slice((array) $this, $offset, 1);

tests/cases/integration/connection.postgres.phpt

@@ -38,7 +38,7 @@ class ConnectionPostgresTest extends IntegrationTestCase
 		Assert::same(2, $this->connection->getLastInsertedId(new Fqn(schema: 'public', name: 'publishers_id_seq')));
 
 		Assert::exception(function() {
-			$this->connection->getLastInsertedId();
+			$_ = $this->connection->getLastInsertedId();
 		}, InvalidArgumentException::class, 'PgsqlDriver requires passing a sequence name for getLastInsertedId() method.');
 	}
 

tests/cases/integration/result.buffering.phpt

@@ -36,7 +36,7 @@ class ResultBufferingIntegrationTest extends IntegrationTestCase
 		$unbuffered = $this->connection->query('SELECT * FROM books ORDER BY id')->buffered()->unbuffered();
 		Assert::same([1, 2, 3, 4], $unbuffered->fetchPairs(null, 'id'));
 		Assert::throws(function () use ($unbuffered): void {
-			$unbuffered->fetchPairs(null, 'id');
+			$_ = $unbuffered->fetchPairs(null, 'id');
 		}, NotSupportedException::class);
 
 		$lateChanged = $this->connection->query('SELECT * FROM books ORDER BY id')->buffered();