Skip to content

fix indices out-of-bounds from issues 10 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmitrimaxwellsymbolica wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix indices out-of-bounds from issues 10 #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions smogn/dist_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def heom_dist(a_num, b_num, d_num, ranges_num, a_nom, b_nom, d_nom):
# import numpy as np

## create list to store distances
dist = [None] * d_num
dist = [None] * (d_num + d_nom)

@nickkunz nickkunz Mar 14, 2024

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledged.


## specify epsilon
eps = 1e-30
Expand All @@ -70,11 +70,11 @@ def heom_dist(a_num, b_num, d_num, ranges_num, a_nom, b_nom, d_nom):
## distance equals 0 for values that are equal
## in two vectors a and b of equal length
if a_nom.iloc[i] == b_nom.iloc[i]:
dist[i] = 0
dist[d_num + i] = 0

## distance equals 1 for values that are not equal
else:
dist[i] = 1
dist[d_num + i] = 1

## theoretically, hamming differences are squared when utilized
## within heom distance, however, procedurally not required,
Expand Down