Skip to content

easyeffects: handle null extra presets - #9722

Merged
khaneliman merged 1 commit into
nix-community:masterfrom
khaneliman:fix/easyeffects-extra-presets
Jul 29, 2026
Merged

easyeffects: handle null extra presets#9722
khaneliman merged 1 commit into
nix-community:masterfrom
khaneliman:fix/easyeffects-extra-presets

Conversation

@khaneliman

Copy link
Copy Markdown
Collaborator

Description

Treat services.easyeffects.extraPresets = null like an empty preset set.
The option type already permits null, but preset generation attempted to map it
as an attribute set.

Keeps paired preset behavior unchanged; #9716 can evolve that separately.

Tested with nix run path:.#tests -- easyeffects.

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -A dev --run treefmt.

  • Code tested through nix build .#test-all
    or a targeted nix run .#tests -- <pattern>.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

@github-actions github-actions Bot added the audio label Jul 28, 2026
@home-manager-ci
home-manager-ci Bot requested review from fufexan and hauskens July 28, 2026 11:28
The option type permits null, but preset generation attempted to map it as an attribute set. Treat null like an empty preset set so users can disable imported presets without evaluation failure.
@khaneliman
khaneliman force-pushed the fix/easyeffects-extra-presets branch from 1b2c899 to 7a4c8d1 Compare July 29, 2026 00:19
@khaneliman
khaneliman merged commit 28942e2 into nix-community:master Jul 29, 2026
7 checks passed
@khaneliman
khaneliman deleted the fix/easyeffects-extra-presets branch July 29, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant