easyeffects: handle null extra presets - #9722
Merged
khaneliman merged 1 commit intoJul 29, 2026
Merged
Conversation
The option type permits null, but preset generation attempted to map it as an attribute set. Treat null like an empty preset set so users can disable imported presets without evaluation failure.
khaneliman
force-pushed
the
fix/easyeffects-extra-presets
branch
from
July 29, 2026 00:19
1b2c899 to
7a4c8d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Treat
services.easyeffects.extraPresets = nulllike an empty preset set.The option type already permits null, but preset generation attempted to map it
as an attribute set.
Keeps paired preset behavior unchanged; #9716 can evolve that separately.
Tested with
nix run path:.#tests -- easyeffects.Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -A dev --run treefmt.Code tested through
nix build .#test-allor a targeted
nix run .#tests -- <pattern>.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.