Skip to content

easyeffects: handle null extra presets #9722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaneliman merged 1 commit into from
Jul 29, 2026
+15 −1
Merged

easyeffects: handle null extra presets #9722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/services/easyeffects.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ in

home.packages = with pkgs; lib.optional olderThan8 at-spi2-core ++ [ cfg.package ]; # Only include if easyeffects version is below 8.0.0

xdg.dataFile = lib.mkIf (cfg.extraPresets != { }) (
xdg.dataFile = lib.mkIf (cfg.extraPresets != null && cfg.extraPresets != { }) (
lib.mapAttrs' (
k: v:
# Assuming only one of either input or output block is defined, having both in same file not seem to be supported by the application since it separates it by folder
Expand Down
1 change: 1 addition & 0 deletions tests/modules/services/easyeffects/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@
lib.optionalAttrs pkgs.stdenv.hostPlatform.isLinux {
easyeffects-service = ./service.nix;
easyeffects-example-preset = ./example-preset.nix;
easyeffects-null-presets = ./null-presets.nix;
}
13 changes: 13 additions & 0 deletions tests/modules/services/easyeffects/null-presets.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
services.easyeffects = {
enable = true;
extraPresets = null;
};

test.stubs.easyeffects = { };

nmt.script = ''
assertPathNotExists home-files/.local/share/easyeffects/input
assertPathNotExists home-files/.local/share/easyeffects/output
'';
}
Loading