fix(frontend): follow aliases when matching method receivers - #13346
Draft
AztecBot wants to merge 3 commits into
Draft
fix(frontend): follow aliases when matching method receivers#13346AztecBot wants to merge 3 commits into
AztecBot wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Method receiver matching only tested the declared receiver type and one raw reference peel. That let alias-wrapped references and nested-reference inherent receivers miss the direct method path, allowing trait methods with the same name to win. This change centralizes receiver matching so it follows bindings and then repeatedly applies the existing auto-deref behavior.
Fix
Testing
cargo test -p noirc_frontend inherent_method_ -- --nocapturecargo fmtIssues
Created by claudebox · group:
noir-audit-remediation