[Shi Haochen] iP by hshiah · Pull Request #77 · nus-cs2113-AY2324S1/ip

hshiah · 2023-09-05T18:32:32Z

Shi Haochen's individual project update.

wwweert123 · 2023-09-07T09:41:16Z

+        String greet = "Hello! I'm Elwin\n" + "What can I do for you?";
+        String line = "_______________________________________________";
+        String exit = "Bye. Hope to see you again soon!";
+        String listRequirements = "Here are the tasks in your list:";


Good job! Use of camelCase

wwweert123 · 2023-09-07T09:42:13Z

-                + "| |_| | |_| |   <  __/\n"
-                + "|____/ \\__,_|_|\\_\\___|\n";
-        System.out.println("Hello from\n" + logo);
+        String greet = "Hello! I'm Elwin\n" + "What can I do for you?";


Can use capital letters for constant eg. GREET

wwweert123 · 2023-09-07T09:43:15Z

+        List<Task> todoList = new ArrayList<>();
+        while(true){
+            String input = scanner.nextLine();
+            if(input.equals("bye")){


Remember to add spacing for if else class statements eg. if (something) {

wwweert123 · 2023-09-07T09:46:24Z

@@ -1,10 +1,56 @@
+import java.util.Scanner;
+import java.util.List;


Good job! names representing packages are in lower case

wwweert123 · 2023-09-07T09:47:49Z

@@ -0,0 +1,25 @@
+public class Task {


Good job use of PascalCase for classes

vvhuiling

Overall, I found your code easy to read for the most part except main class appears to be a bit packed. Perhaps we can add some blank lines to improve readability. And perhaps encapsulate some of its functionalities if that make sense!

vvhuiling · 2023-09-07T09:51:13Z

+                todoList.get(index-1).markAsDone();
+                System.out.println(line);
+                System.out.println(markRequirements);
+                System.out.println("  [" + todoList.get(index-1).getStatusIcon() + "] " + todoList.get(index-1).getDescription());


Perhaps spilt the code into 2 lines evenly? first line looks a bit to long for me. I noticed the same issue in several other places too.

vvhuiling · 2023-09-07T09:57:14Z

+        String markFormat = "^mark \\d+$";
+        String unmarkFormat = "^unmark \\d+$";


I have some confusion regarding these strings. Can you provide some clarification on their meaning?

vvhuiling · 2023-09-07T10:00:34Z

+        while(true){
+            String input = scanner.nextLine();
+            if(input.equals("bye")){
+                break;
+            }else if(input.equals("list")){
+                System.out.println(line);
+                System.out.println(listRequirements);
+                for(int i = 0; i < todoList.size(); i++){
+                    System.out.println(i+1 + ".[" + todoList.get(i).getStatusIcon() + "] " + todoList.get(i).getDescription());
+                }
+                System.out.println(line);
+            }else if(input.matches(markFormat)) {
+                int index = Integer.parseInt(input.substring(5));
+                todoList.get(index-1).markAsDone();
+                System.out.println(line);
+                System.out.println(markRequirements);
+                System.out.println("  [" + todoList.get(index-1).getStatusIcon() + "] " + todoList.get(index-1).getDescription());


Perhaps encapsulate some of its functionalities into separate methods so that this while loop can be more concise.

vvhuiling · 2023-09-07T10:03:04Z

-        System.out.println("Hello from\n" + logo);
+        String greet = "Hello! I'm Elwin\n" + "What can I do for you?";
+        String line = "_______________________________________________";
+        String exit = "Bye. Hope to see you again soon!";


Since this line is used only once, should it be extracted out and just print it directly when needed?

maanyos

Generally good adherence to coding standards. Some variable names can be improved to be more informative.
Good use of execeptions

maanyos · 2023-09-17T09:34:27Z

+import java.util.List;
+import java.util.ArrayList;
 public class Duke {
+    protected final static String line = "_______________________________________________";


follow the correct naming standard for constants

maanyos · 2023-09-17T09:35:35Z

-                + "|____/ \\__,_|_|\\_\\___|\n";
-        System.out.println("Hello from\n" + logo);
+        String greet = "Hello! I'm Elwin\n" + "What can I do for you?";
+        //String line = "_______________________________________________";


remove unecessary code

hshiah added 2 commits September 5, 2023 21:50

Level-0

cd6d347

Week 3 changes

13ec220

wwweert123 reviewed Sep 7, 2023

View reviewed changes

vvhuiling reviewed Sep 7, 2023

View reviewed changes

Level 5

18f70b5

maanyos reviewed Sep 17, 2023

View reviewed changes

hshiah added 5 commits September 18, 2023 21:42

Code Improvement

71a2724

Add increment level 6 and 7.

69f1c6c

update README

4d8d6ec

Level-9

faddc9e

Fix wrong output for find task.

b800f93

		@@ -1,10 +1,56 @@
		import java.util.Scanner;
		import java.util.List;

		String markFormat = "^mark \\d+$";
		String unmarkFormat = "^unmark \\d+$";

Uh oh!

Conversation

hshiah commented Sep 5, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vvhuiling left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maanyos left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants