Merged
Conversation
… and Verilator waveforms; checked new code works. Without waveforms, Claude timed out.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a cbo.zero (Zicboz) corner case in the cache FSM where a zeroing operation with no dirty eviction needs to stall and force an SRAM re-read on the following cycle to ensure correct behavior.
Changes:
- Add an explicit
STATE_ACCESS -> STATE_ADDRESS_SETUPtransition forCMOZeroNoEviction(cbo.zerowith no dirty writeback needed). - Extend
StallConditions(and thereforeCacheStall) to includeCMOZeroNoEvictionso the pipeline is stalled for the required extra cycle.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jordancarlin
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug found and fixed by Claude looking at code and Verilator waveforms; checked new code works. Without waveforms, Claude timed out.