ARR: Merge Post-Submission and Preprint Release#2908
ARR: Merge Post-Submission and Preprint Release#2908haroldrubio wants to merge 35 commits intomasterfrom
Conversation
|
|
||
| def create_post_submission_stage(self): | ||
| return self.venue.create_post_submission_stage() | ||
| self.venue.create_post_submission_stage() |
There was a problem hiding this comment.
what if you create the Post_Submission invitation here? or pass the process function path as a param?
| note=updated_note | ||
| ) | ||
|
|
||
| openreview.tools.concurrent_requests( |
There was a problem hiding this comment.
This seems to be two different types of post_submission invitations so I would try doing that:
- Post_Submission: post edits for all the submissions where preprint == No. This can be specified as a source parameter in the same invitation.
- Preprint_Post_Submission: post edits for all the submissions where preprint == Yes. This can be specified as the source parameter in the same invitation
@celestemartinez this is something that we discussed yesterday and this is a good case to support it.
- specify the source in the invitation.content
- process function get the submissions from the source
3 apply the edits
|
@haroldrubio with this PR merged: #2934 Can you try creating two different Post_Submission invitations with different sources? |
There was a problem hiding this comment.
Pull request overview
This PR resolves #2809 by removing the standalone ARR “Preprint Release” step and incorporating preprint handling into an ARR-specific post-submission date process, reducing the chance of race conditions between multiple processes updating submissions.
Changes:
- Introduces an ARR-specific
post_submission_process.pythat handles both preprint and non-preprint post-submission behavior based on invitationcontent.sourcefilters. - Creates a new
Preprint_Post_Submissioninvitation alongside the existingPost_Submissioninvitation, each targeting a disjoint submission set (preprint: yesvspreprint: no). - Removes the legacy preprint release workflow stage/configuration and updates ARR venue tests accordingly.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tests/test_arr_venue_v2.py |
Updates tests to assert creation/execution of Preprint_Post_Submission and validates updated reader behavior for released preprints. |
openreview/venue/invitation.py |
Generalizes set_post_submission_invitation to accept custom invitation id, source filters, and process script path. |
openreview/arr/process/preprint_release_submission_process.py |
Removes the legacy dedicated preprint release process script. |
openreview/arr/process/post_submission_process.py |
Adds ARR-specific post-submission processing, including releasing preprints by updating note readers/field-level readers. |
openreview/arr/invitation.py |
Adds ARR wrapper support for post-submission invitation customization (but currently contains duplicate method definitions). |
openreview/arr/helpers.py |
Removes the configuration field and workflow stage for preprint_release_submission_date. |
openreview/arr/arr.py |
Updates stage creation to create two post-submission invitations (preprint + non-preprint) using the ARR-specific process. |
Comments suppressed due to low confidence (1)
openreview/arr/invitation.py:258
InvitationBuilderdefinesset_submission_message_invitationtwice; the later definition overwrites the earlier one. Please keep only one definition to prevent shadowing bugs and make the public API of the class clearer.
def set_submission_message_invitation(self):
return self.venue_invitation_builder.set_submission_message_invitation()
def set_iThenticate_plagiarism_check_invitation(self):
return self.venue_invitation_builder.set_iThenticate_plagiarism_check_invitation()
def set_submission_deletion_invitation(self, submission_revision_stage):
return self.venue_invitation_builder.set_submission_deletion_invitation(submission_revision_stage)
def set_review_invitation(self):
return self.venue_invitation_builder.set_review_invitation()
def update_review_invitations(self):
return self.venue_invitation_builder.update_review_invitations()
def set_review_rebuttal_invitation(self):
return self.venue_invitation_builder.set_review_rebuttal_invitation()
def set_meta_review_invitation(self):
return self.venue_invitation_builder.set_meta_review_invitation()
def set_recruitment_invitation(self, committee_name, options):
return self.venue_invitation_builder.set_recruitment_invitation(committee_name, options)
def set_bid_invitations(self):
return self.venue_invitation_builder.set_bid_invitations()
def set_official_comment_invitation(self):
return self.venue_invitation_builder.set_official_comment_invitation()
def set_submission_message_invitation(self):
return self.venue_invitation_builder.set_submission_message_invitation()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| def set_submission_deletion_invitation(self, submission_revision_stage): | ||
| return self.venue_invitation_builder.set_submission_deletion_invitation(submission_revision_stage) | ||
|
|
There was a problem hiding this comment.
InvitationBuilder defines set_submission_deletion_invitation twice (the second definition overwrites the first). Please remove the duplicate method to avoid confusion and accidental divergence if one copy is changed later.
| def set_submission_deletion_invitation(self, submission_revision_stage): | |
| return self.venue_invitation_builder.set_submission_deletion_invitation(submission_revision_stage) |
| return invitation | ||
|
|
||
| def set_post_submission_invitation(self): | ||
| def set_post_submission_invitation(self, invitation_id=None, source=None, process_path='process/post_submission_process.py'): |
There was a problem hiding this comment.
Why do you need to make these changes to the venue invitation? ARR is not using this set_post_submission_invitation anymore, right?
There was a problem hiding this comment.
Something I still need is the ability to change the source, so only the non-preprints go through the usual post submission invitation - but I removed the rest
This PR merges the post submission and preprint release steps in the ARR workflow into an ARR-specific post-submission dateprocess