ARR: Merge Post-Submission and Preprint Release

openreview/arr/arr.py

@@ -219,6 +219,13 @@ def get_meta_invitation_id(self):
     def get_submission_id(self):
         return self.venue.get_submission_id()
 
+    def get_post_submission_id(self):
+        return self.venue.get_post_submission_id()
+
+    def get_preprint_post_submission_id(self):
+        submission_name = self.submission_stage.name if self.submission_stage else self.venue.submission_stage.name
+        return self.get_invitation_id(f'Preprint_Post_{submission_name}')
+
     def get_pc_submission_revision_id(self):
         return self.venue.get_pc_submission_revision_id()
 
@@ -427,7 +434,40 @@ def recruit_reviewers(self,
 
     # For stage invitations, pass value to inner venue objects
     def create_submission_stage(self):
-        stage_value = self.venue.create_submission_stage()
+        self.invitation_builder.set_submission_invitation()
+        if self.venue.iThenticate_plagiarism_check:
+            self.invitation_builder.set_iThenticate_plagiarism_check_invitation()
+        self.invitation_builder.set_withdrawal_invitation()
+        self.invitation_builder.set_desk_rejection_invitation()
+        self.invitation_builder.set_post_submission_invitation()
+        self.invitation_builder.set_preprint_post_submission_invitation()
+        self.invitation_builder.set_pc_submission_revision_invitation()
+        self.invitation_builder.set_submission_reviewer_group_invitation()
+        self.invitation_builder.set_submission_message_invitation()
+        if self.use_area_chairs:
+            self.invitation_builder.set_submission_area_chair_group_invitation()
+        if self.use_senior_area_chairs:
+            self.invitation_builder.set_submission_senior_area_chair_group_invitation()
+        if self.expertise_selection_stage:
+            self.invitation_builder.set_expertise_selection_invitations()
+
+        if self.submission_stage.second_due_date:
+            stage = self.submission_stage
+            submission_revision_stage = openreview.stages.SubmissionRevisionStage(
+                name=f'Full_{stage.name}',
+                start_date=stage.exp_date,
+                due_date=stage.second_due_date,
+                additional_fields=stage.second_deadline_additional_fields if stage.second_deadline_additional_fields else stage.additional_fields,
+                remove_fields=stage.second_deadline_remove_fields if stage.second_deadline_remove_fields else stage.remove_fields,
+                only_accepted=False,
+                multiReply=True,
+                allow_author_reorder=stage.author_reorder_after_first_deadline,
+                allow_license_edition=True,
+                source={'venueid': self.get_submission_venue_id()}
+            )
+            self.invitation_builder.set_submission_revision_invitation(submission_revision_stage)
+            self.invitation_builder.set_submission_deletion_invitation(submission_revision_stage)
+
         invitation = self.client.get_invitation(self.get_submission_id())
         invitation.preprocess = self.invitation_builder.get_process_content('process/submission_preprocess.py')
         invitation.process = invitation.process + self.invitation_builder.get_process_content('process/submission_process_extension.py')
@@ -440,10 +480,10 @@ def create_submission_stage(self):
             replacement=False,
             invitation=invitation
         )
-        return stage_value
 
     def create_post_submission_stage(self):
-        return self.venue.create_post_submission_stage()
+        self.invitation_builder.set_post_submission_invitation()
+        self.invitation_builder.set_preprint_post_submission_invitation()
 
     def create_submission_revision_stage(self):
         self.venue.submission_revision_stage = self.submission_revision_stage

openreview/arr/helpers.py

@@ -36,8 +36,6 @@
     arr_metareview_license_task,
     arr_metareview_license_task_forum,
     arr_metareview_rating_content,
-    hide_fields_from_public,
-    hide_fields,
     arr_submitted_author_forum,
     arr_submitted_author_content,
     arr_delay_notification_content,
@@ -147,12 +145,6 @@ class ARRWorkflow(object):
             "order": 14,
             "required": False
         },
-        "preprint_release_submission_date": {
-            "description": "When should submissions be copied over and the opt-in papers be revealed to the public? This should be done several hours (12+ hours) after the submission deadline.",
-            "value-regex": "^[0-9]{4}\\/([1-9]|0[1-9]|1[0-2])\\/([1-9]|0[1-9]|[1-2][0-9]|3[0-1])(\\s+)?((2[0-3]|[01][0-9]|[0-9]):[0-5][0-9])?(\\s+)?$",
-            "order": 15,
-            "required": False
-        },
         "setup_sae_ae_assignment_date": {
             "description": "When will both SAE and AE assignments be deployed? This must happen after both assignments are deployed to give SAEs access to the AE assignments.",
             "value-regex": "^[0-9]{4}\\/([1-9]|0[1-9]|1[0-2])\\/([1-9]|0[1-9]|[1-2][0-9]|3[0-1])(\\s+)?((2[0-3]|[01][0-9]|[0-9]):[0-5][0-9])?(\\s+)?$",
@@ -396,64 +388,6 @@ class ARRWorkflow(object):
 }
 
 
-    @staticmethod
-    def _build_preprint_release_edit(client, venue, builder, request_form):
-        venue_id = venue.id
-        submission_stage = venue.submission_stage
-
-        submission_id = submission_stage.get_submission_id(venue)
-
-        hidden_field_names = hide_fields_from_public
-        committee_members = venue.get_committee(number='${{4/id}/number}', with_authors=True)
-        note_content = { f: { 'readers': committee_members } for f in hidden_field_names}
-
-        # Always hide authors and authorids
-        author_readers = [venue_id, venue.get_authors_id(number='${{4/id}/number}')]
-        note_content['authors'] = { 'readers': author_readers }
-        note_content['authorids'] = { 'readers': author_readers }
-        for field in hide_fields:
-            note_content[field] = { 'readers': author_readers }
-
-        edit = {
-            'signatures': [venue_id],
-            'readers': [venue_id, venue.get_authors_id('${{2/note/id}/number}')],
-            'writers': [venue_id],
-            'note': {
-                'id': {
-                    'param': {
-                        'withInvitation': submission_id,
-                        'optional': True
-                    }
-                },
-                'odate': {
-                    'param': {
-                        'range': [ 0, 9999999999999 ],
-                        'optional': True,
-                        'deletable': True
-                    }
-                },
-                'signatures': [ venue.get_authors_id('${{2/id}/number}') ],
-                'readers': ['everyone'],
-                'writers': [venue_id, venue.get_authors_id('${{2/id}/number}')],
-            }
-        }
-
-        note_content['_bibtex'] = {
-            'value': {
-                'param': {
-                    'type': 'string',
-                    'maxLength': 200000,
-                    'input': 'textarea',
-                    'optional': True
-                }
-            }
-        }
-
-        if note_content:
-            edit['note']['content'] = note_content
-
-        return {'edit': edit}
-
     @staticmethod
     def _extend_desk_reject_verification(client, venue, builder, request_form):
         venue.invitation_builder.set_verification_flag_invitation()
@@ -588,15 +522,6 @@ def __init__(self, client_v2, venue, configuration_note, request_form_id, suppor
         request_form = self.client.get_note(request_form_id)
 
         self.workflow_stages = [
-            ARRStage(
-                type=ARRStage.Type.PROCESS_INVITATION,
-                required_fields=['preprint_release_submission_date'],
-                super_invitation_id=f"{self.venue_id}/-/Preprint_Release_{venue.submission_stage.name}",
-                stage_arguments={},
-                start_date=self.configuration_note.content.get('preprint_release_submission_date'),
-                process='process/preprint_release_submission_process.py',
-                build_edit=ARRWorkflow._build_preprint_release_edit
-            ),
             ARRStage(
                 type=ARRStage.Type.PROCESS_INVITATION,
                 required_fields=['setup_shared_data_date', 'previous_cycle'],

openreview/arr/invitation.py

@@ -198,18 +198,145 @@ def set_preferred_emails_invitation(self):
     def set_submission_invitation(self):
         return self.venue_invitation_builder.set_submission_invitation()
 
+    def set_post_submission_invitation(self, invitation_id=None, source=None):
+        if source is None:
+            source = {
+                'venueid': self.venue.get_submission_venue_id(),
+                'content':{
+                    'preprint': 'no'
+                }
+            }
+
+        return self.venue_invitation_builder.set_post_submission_invitation(
+            invitation_id=invitation_id,
+            source=source
+        )
+
+    def set_preprint_post_submission_invitation(self):
+        if self.venue.is_template_related_workflow():
+            return
+
+        venue_id = self.venue_id
+        submission_stage = self.venue.submission_stage
+        submission_id = submission_stage.get_submission_id(self.venue)
+        invitation_id = self.venue.get_preprint_post_submission_id()
+        source = {
+            'venueid': self.venue.get_submission_venue_id(),
+            'content': {
+                'preprint': 'yes'
+            }
+        }
+        post_submission_cdate = tools.datetime_millis(submission_stage.exp_date) if submission_stage.exp_date else None
+        number_param = '${{4/id}/number}'
+        authors_id = self.venue.get_authors_id(number_param)
+        hidden_field_names = submission_stage.get_hidden_field_names()
+        note_content = {
+            field: {
+                'readers': [venue_id, authors_id]
+            } for field in hidden_field_names
+        }
+        committee_readers = [
+            self.venue.get_program_chairs_id(),
+            self.venue.get_senior_area_chairs_id(number_param),
+            self.venue.get_area_chairs_id(number_param),
+            self.venue.get_reviewers_id(number_param),
+            authors_id
+        ]
+
+        existing_invitation = tools.get_invitation(self.client, invitation_id)
+        if existing_invitation and 'content' in existing_invitation.edit['note']:
+            for field, value in existing_invitation.edit['note']['content'].items():
+                if field not in hidden_field_names and 'readers' in value:
+                    note_content[field] = {
+                        'readers': {
+                            'param': {
+                                'const': {
+                                    'delete': True
+                                }
+                            }
+                        }
+                    }
+
+        for field in hide_fields_from_public:
+            note_content[field] = {
+                'readers': committee_readers
+            }
+
+        note_content['_bibtex'] = {
+            'value': {
+                'param': {
+                    'type': 'string',
+                    'maxLength': 200000,
+                    'input': 'textarea',
+                    'optional': True,
+                    'deletable': True
+                }
+            }
+        }
+
+        invitation = Invitation(
+            id=invitation_id,
+            invitees=[venue_id],
+            signatures=[venue_id],
+            readers=[venue_id],
+            writers=[venue_id],
+            cdate=post_submission_cdate,
+            date_processes=[{
+                'dates': ["#{4/cdate}", self.update_date_string],
+                'script': self.get_process_content('../venue/process/post_submission_process.py')
+            }],
+            content={
+                'source': {
+                    'value': source
+                }
+            },
+            edit={
+                'signatures': [venue_id],
+                'readers': [venue_id, self.venue.get_authors_id('${{2/note/id}/number}')],
+                'writers': [venue_id],
+                'note': {
+                    'id': {
+                        'param': {
+                            'withInvitation': submission_id,
+                            'optional': True
+                        }
+                    },
+                    'odate': {
+                        'param': {
+                            'range': [0, 9999999999999],
+                            'optional': True,
+                            'deletable': True
+                        }
+                    },
+                    'signatures': [self.venue.get_authors_id('${{2/id}/number}')],
+                    'readers': ['everyone'],
+                    'writers': [venue_id, self.venue.get_authors_id('${{2/id}/number}')],
+                    'content': note_content
+                }
+            }
+        )
+
+        self.save_invitation(invitation, replacement=False)
+        return invitation
+
     def set_submission_deletion_invitation(self, submission_revision_stage):
         return self.venue_invitation_builder.set_submission_deletion_invitation(submission_revision_stage)
 
-    def set_post_submission_invitation(self):
-        return self.venue_invitation_builder.set_post_submission_invitation()
-
     def set_submission_change_invitation(self, name, activation_date):
         return self.venue_invitation_builder.set_submission_change_invitation(name, activation_date)
 
     def set_pc_submission_revision_invitation(self):
         return self.venue_invitation_builder.set_pc_submission_revision_invitation()
 
+    def set_submission_message_invitation(self):
+        return self.venue_invitation_builder.set_submission_message_invitation()
+
+    def set_iThenticate_plagiarism_check_invitation(self):
+        return self.venue_invitation_builder.set_iThenticate_plagiarism_check_invitation()
+
+    def set_submission_deletion_invitation(self, submission_revision_stage):
+        return self.venue_invitation_builder.set_submission_deletion_invitation(submission_revision_stage)
+
     def set_review_invitation(self):
         return self.venue_invitation_builder.set_review_invitation()