STOR-3005: Remove v1beta2 group snapshot API

[jsafrane]

We don't want any beta APIs served for GA features.

Summary by CodeRabbit

• Bug Fixes
  • Removed the older v1beta2 API version from volume group snapshot resources, leaving v1 as the only active version.
  • Updated the published CRDs and related webhook admission configuration so the deprecated version is no longer offered in the platform.

[openshift-ci-robot]

@jsafrane: This pull request references STOR-3005 which is a valid jira issue.

Details

In response to this:

We don't want any beta APIs served for GA features.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jsafrane]

/hold
for openshift/kubernetes#2715 to merge

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5d507b60-17dd-459d-866a-4a3059cc3887

📥 Commits

Reviewing files that changed from the base of the PR and between 45acd41 and 2267501.

📒 Files selected for processing (4)

• assets/volumegroupsnapshotclasses.yaml
• assets/volumegroupsnapshotcontents.yaml
• assets/volumegroupsnapshots.yaml
• assets/webhook_config.yaml

🚧 Files skipped from review as they are similar to previous changes (3)

• assets/volumegroupsnapshotclasses.yaml
• assets/volumegroupsnapshotcontents.yaml
• assets/volumegroupsnapshots.yaml

---

Walkthrough

The volume group snapshot CRD assets now comment out v1beta2 definitions, leaving v1 active, and the volumegroupsnapshotclasses webhook now advertises only v1.

Changes

v1beta2 CRD version removal

Layer / File(s)	Summary
CRD and webhook version gating assets/volumegroupsnapshotclasses.yaml, assets/volumegroupsnapshotcontents.yaml, assets/volumegroupsnapshots.yaml, assets/webhook_config.yaml	The v1beta2 CRD version blocks are commented out across the three volume group snapshot manifests, and the volumegroupsnapshotclasses webhook apiVersions list is reduced to v1.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: removing the v1beta2 group snapshot API.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only changes CRD/webhook YAML assets; no Go/Ginkgo test files or test titles were added or modified.
Test Structure And Quality	✅ Passed	Diff only changes asset YAMLs/webhook config; no Ginkgo test files or test code were touched, so the test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	Diff only changes CRD/webhook YAML; no new Ginkgo tests or MicroShift-unsafe APIs/features were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR only changes YAML CRD/webhook assets; no Ginkgo e2e tests were added or modified, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only CRD version gating and webhook apiVersions changed; no node selectors, affinity, spread constraints, replicas, or tolerations were added.
Ote Binary Stdout Contract	✅ Passed	PR only changes YAML CRD/webhook assets; no process-level binaries or stdout logging code were touched.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only changes YAML assets; no new Ginkgo e2e tests or network-sensitive test code were added.
No-Weak-Crypto	✅ Passed	Only YAML CRD/webhook version changes were found; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	Changed files are CRDs/webhook config only; no privileged, host* , SYS_ADMIN, or allowPrivilegeEscalation settings appear in the PR diff.
No-Sensitive-Data-In-Logs	✅ Passed	Touched files are CRD/webhook YAML only; diff only comments out v1beta2 and changes apiVersions. No new log statements or sensitive literals found.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

assets/volumegroupsnapshotclasses.yaml (1)

21-21: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Stale rationale comment now contradicts the change.

This line explains why v1beta1 is disabled but asserts that v1beta2 is "served without conversion." With the v1beta2 block commented out below, that statement is now misleading to future maintainers. Consider trimming the v1beta2 reference here (it applies to all three CRD assets).

📝 Suggested wording

-# Don't offer v1beta1 API in OCP, it needs a conversion webhook. v1 and v1beta2 are compatible and served without conversion.
+# Don't offer v1beta1 API in OCP, it needs a conversion webhook. Only v1 is served (v1beta2 is disabled below).

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@assets/volumegroupsnapshotclasses.yaml` at line 21, The rationale comment
above the CRD version blocks is stale and now misleading because it mentions
v1beta2 as served without conversion even though that block is commented out.
Update the comment in the volume snapshot class CRD assets to only explain why
v1beta1 is disabled, and remove the v1beta2-specific wording so the note matches
the current served versions.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@assets/volumegroupsnapshotclasses.yaml`:
- Around line 180-263: The webhook configuration still lists the removed v1beta2
API for VolumeGroupSnapshotClass, so update the webhook rules to stop
advertising it. In assets/webhook_config.yaml, adjust the rule for
volumegroupsnapshotclasses so apiVersions only includes v1, matching the current
supported version and the removal of v1beta2 from
volumegroupsnapshotclasses.yaml.

---

Outside diff comments:
In `@assets/volumegroupsnapshotclasses.yaml`:
- Line 21: The rationale comment above the CRD version blocks is stale and now
misleading because it mentions v1beta2 as served without conversion even though
that block is commented out. Update the comment in the volume snapshot class CRD
assets to only explain why v1beta1 is disabled, and remove the v1beta2-specific
wording so the note matches the current served versions.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e3b4f22c-c9ac-4dc2-8f81-98e68729ad09

📥 Commits

Reviewing files that changed from the base of the PR and between ef7a4c8 and 45acd41.

📒 Files selected for processing (3)

• assets/volumegroupsnapshotclasses.yaml
• assets/volumegroupsnapshotcontents.yaml
• assets/volumegroupsnapshots.yaml

[openshift-ci]

@jsafrane: This PR was included in a payload test run from openshift/kubernetes#2715
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f6adc880-7b8f-11f1-9158-14ae2cd3eb2e-0

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jsafrane: This PR was included in a payload test run from openshift/kubernetes#2715
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d9b91ad0-7b90-11f1-8f21-2bd69de242cc-0

[openshift-ci]

@jsafrane: This PR was included in a payload test run from openshift/kubernetes#2715
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ffde5490-7baf-11f1-8c92-8b6201752e13-0

[openshift-ci]

@rvagner78: This PR was included in a payload test run from openshift/kubernetes#2723
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fc81f010-85a8-11f1-9c0f-837c9ad85463-0

[openshift-ci]

@rvagner78: This PR was included in a payload test run from openshift/kubernetes#2723
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e545e060-85b6-11f1-8987-0ab5c8304063-0