STOR-2961: UPSTREAM: 138768: move VolumeGroupSnapshot to V1 by rvagner78 · Pull Request #2723 · openshift/kubernetes

rvagner78 · 2026-07-22T07:59:46Z

Summary

Cherry-pick of upstream move VolumeGroupSnapshot to V1 kubernetes/kubernetes#138768 (now merged)
Updates VolumeGroupSnapshot e2e tests to use v1 group snapshot API
Adds v1 CRD manifests for VolumeGroupSnapshot, VolumeGroupSnapshotClass, VolumeGroupSnapshotContent
Bumps external-snapshotter from v8.4.0 to v8.6.0 in run_group_snapshot_e2e.sh

Supersedes #2715

Summary by CodeRabbit

New Features
- Added support for the stable v1 Volume Group Snapshot API.
- Updated snapshot resource definitions with schemas, validation rules, status fields, and printer columns.
- Volume Group Snapshot resources now use v1 as the storage version.
Bug Fixes
- Prevented modification of immutable snapshot fields after they are initially set.
Tests
- Updated end-to-end snapshot testing to use external-snapshotter version 8.6.0.

Cherry-pick of upstream kubernetes#138768. Updates VolumeGroupSnapshot e2e tests to use v1 group snapshot API, adds v1 CRDs, and bumps external-snapshotter to v8.6.0.

openshift-ci-robot · 2026-07-22T07:59:50Z

@rvagner78: This pull request references STOR-2961 which is a valid jira issue.

Details

In response to this:

Summary

Cherry-pick of upstream move VolumeGroupSnapshot to V1 kubernetes/kubernetes#138768 (now merged)

Updates VolumeGroupSnapshot e2e tests to use v1 group snapshot API

Adds v1 CRD manifests for VolumeGroupSnapshot, VolumeGroupSnapshotClass, VolumeGroupSnapshotContent

Bumps external-snapshotter from v8.4.0 to v8.6.0 in run_group_snapshot_e2e.sh

Supersedes #2715

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-07-22T07:59:57Z

@rvagner78: the contents of this pull request could be automatically validated.

The following commits are valid:

a64f202|UPSTREAM: 138768: move VolumeGroupSnapshot to V1: the upstream PR kubernetes/kubernetes#138768 has merged

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

coderabbitai · 2026-07-22T08:00:20Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: aa9dd341-dc8a-49e5-9235-78c85bd6c825

📥 Commits

Reviewing files that changed from the base of the PR and between 0f7d1a1 and a64f202.

📒 Files selected for processing (5)

test/e2e/storage/utils/volume_group_snapshot.go
test/e2e/testing-manifests/storage-csi/external-snapshotter/groupsnapshot.storage.k8s.io_volumegroupsnapshotclasses.yaml
test/e2e/testing-manifests/storage-csi/external-snapshotter/groupsnapshot.storage.k8s.io_volumegroupsnapshotcontents.yaml
test/e2e/testing-manifests/storage-csi/external-snapshotter/groupsnapshot.storage.k8s.io_volumegroupsnapshots.yaml
test/e2e/testing-manifests/storage-csi/external-snapshotter/volume-group-snapshots/run_group_snapshot_e2e.sh

Walkthrough

The change adds served and storage-selected GroupSnapshot v1 CRD versions, updates E2E utilities to use v1 resource identifiers, and advances the external-snapshotter version used by the group snapshot E2E script.

Changes

Group Snapshot API v1

Layer / File(s)	Summary
Add GroupSnapshot v1 CRD definitions `test/e2e/testing-manifests/storage-csi/external-snapshotter/groupsnapshot.storage.k8s.io_volumegroupsnapshotclasses.yaml`, `test/e2e/testing-manifests/storage-csi/external-snapshotter/groupsnapshot.storage.k8s.io_volumegroupsnapshotcontents.yaml`, `test/e2e/testing-manifests/storage-csi/external-snapshotter/groupsnapshot.storage.k8s.io_volumegroupsnapshots.yaml`	Adds served v1 schemas for group snapshot resources, applies immutability and field relationship validations, and selects v1 as the storage version.
Align E2E resource utilities `test/e2e/storage/utils/volume_group_snapshot.go`	Changes the GroupSnapshot API constant and all related GroupVersionResource definitions from v1beta2 to v1.
Update snapshotter E2E version `test/e2e/testing-manifests/storage-csi/external-snapshotter/volume-group-snapshots/run_group_snapshot_e2e.sh`	Changes the default external-snapshotter version from v8.4.0 to v8.6.0.

Estimated code review effort: 3 (Moderate) | ~30 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Ipv6 And Disconnected Network Test Compatibility	⚠️ Warning	The e2e runner fetches setup-snapshot-controller.yaml from raw.githubusercontent.com, so it requires public internet and is not disconnected-safe.	Mirror the snapshot-controller manifest in-repo or via internal registry, and avoid public raw.githubusercontent.com fetches in the e2e path.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: moving VolumeGroupSnapshot to v1.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Changed files contain only a helper Go file, manifests, and a shell script; no It/Describe/Context/When titles were added or modified.
Test Structure And Quality	✅ Passed	No Ginkgo test blocks were modified; only API version constants, CRD manifests, and a snapshotter version bump changed.
Microshift Test Compatibility	✅ Passed	The PR only updates group-snapshot helpers/CRDs and a shell harness; no new Ginkgo specs or MicroShift-incompatible OpenShift APIs/features were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo It/Describe/Context/When specs were added; changes are utility, manifests, and a script update only.
Topology-Aware Scheduling Compatibility	✅ Passed	Changed files are CRDs and a test script; no node selectors, affinity, tolerations, PDBs, or replica logic were added.
Ote Binary Stdout Contract	✅ Passed	No process-level stdout writes were added: the Go utility only uses framework.Logf and has no main/init/suite code; other touched files are YAML/shell script.
No-Weak-Crypto	✅ Passed	No MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, crypto imports, or constant-time issues appear in the touched files; changes are only API version/manifests.
Container-Privileges	✅ Passed	Touched files only update group snapshot API/CRD versions; searches found no privileged, hostPID/Network/IPC, allowPrivilegeEscalation, SYS_ADMIN, or root settings.
No-Sensitive-Data-In-Logs	✅ Passed	No new sensitive logging was added; the diff only updates API versions/CRDs and bumps SNAPSHOTTER_VERSION, with no password/token/PII log output.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-07-22T08:01:27Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rvagner78
Once this PR has been reviewed and has the lgtm label, please assign benluddy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-07-22T08:04:13Z

@rvagner78: This pull request references STOR-2961 which is a valid jira issue.

Details

In response to this:

Summary

Cherry-pick of upstream move VolumeGroupSnapshot to V1 kubernetes/kubernetes#138768 (now merged)

Updates VolumeGroupSnapshot e2e tests to use v1 group snapshot API

Adds v1 CRD manifests for VolumeGroupSnapshot, VolumeGroupSnapshotClass, VolumeGroupSnapshotContent

Bumps external-snapshotter from v8.4.0 to v8.6.0 in run_group_snapshot_e2e.sh

Supersedes #2715

Summary by CodeRabbit

New Features

Added support for the stable v1 Volume Group Snapshot API.

Updated snapshot resource definitions with schemas, validation rules, status fields, and printer columns.

Volume Group Snapshot resources now use v1 as the storage version.

Bug Fixes

Prevented modification of immutable snapshot fields after they are initially set.

Tests

Updated end-to-end snapshot testing to use external-snapshotter version 8.6.0.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rvagner78 · 2026-07-22T08:40:24Z

/payload-job-with-prs periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview openshift/cluster-csi-snapshot-controller-operator#283

openshift-ci · 2026-07-22T08:40:35Z

@rvagner78: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fc81f010-85a8-11f1-9c0f-837c9ad85463-0

rvagner78 · 2026-07-22T10:19:59Z

/payload-job-with-prs periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview openshift/cluster-csi-snapshot-controller-operator#283

openshift-ci · 2026-07-22T10:20:02Z

@rvagner78: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e545e060-85b6-11f1-8987-0ab5c8304063-0

rvagner78 · 2026-07-22T10:25:17Z

/retest

rvagner78 · 2026-07-22T11:13:14Z

/test unit

openshift-ci · 2026-07-22T15:03:01Z

@rvagner78: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-techpreview-serial-2of2	`a64f202`	link	false	`/test e2e-aws-ovn-techpreview-serial-2of2`
ci/prow/e2e-aws-ovn-cgroupsv2	`a64f202`	link	true	`/test e2e-aws-ovn-cgroupsv2`
ci/prow/e2e-aws-ovn-techpreview-serial-1of2	`a64f202`	link	false	`/test e2e-aws-ovn-techpreview-serial-1of2`
ci/prow/e2e-aws-ovn-fips	`a64f202`	link	true	`/test e2e-aws-ovn-fips`
ci/prow/e2e-gcp	`a64f202`	link	true	`/test e2e-gcp`
ci/prow/e2e-metal-ipi-ovn-ipv6	`a64f202`	link	true	`/test e2e-metal-ipi-ovn-ipv6`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rvagner78 · 2026-07-22T15:03:33Z

/retest

UPSTREAM: 138768: move VolumeGroupSnapshot to V1

a64f202

Cherry-pick of upstream kubernetes#138768. Updates VolumeGroupSnapshot e2e tests to use v1 group snapshot API, adds v1 CRDs, and bumps external-snapshotter to v8.6.0.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 22, 2026

openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Jul 22, 2026

openshift-ci Bot requested review from jerpeter1 and jubittajohn July 22, 2026 08:01

openshift-ci Bot mentioned this pull request Jul 22, 2026

STOR-3005: Remove v1beta2 group snapshot API openshift/cluster-csi-snapshot-controller-operator#283

Open

Uh oh!

Conversation

rvagner78 commented Jul 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Jul 22, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

openshift-ci-robot commented Jul 22, 2026

Uh oh!

coderabbitai Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

openshift-ci Bot commented Jul 22, 2026

Uh oh!

openshift-ci-robot commented Jul 22, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Summary by CodeRabbit

Uh oh!

rvagner78 commented Jul 22, 2026

Uh oh!

openshift-ci Bot commented Jul 22, 2026

Uh oh!

rvagner78 commented Jul 22, 2026

Uh oh!

openshift-ci Bot commented Jul 22, 2026

Uh oh!

rvagner78 commented Jul 22, 2026

Uh oh!

rvagner78 commented Jul 22, 2026

Uh oh!

openshift-ci Bot commented Jul 22, 2026

Uh oh!

rvagner78 commented Jul 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rvagner78 commented Jul 22, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Jul 22, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading

openshift-ci-robot commented Jul 22, 2026 •

edited by openshift-ci Bot

Loading