lynx: update to 2.9.3 - #30286
Conversation
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Verified the upgrade target independently, since I have no network access to the tarball hosts from here: PKG_HASH:=174b7f28…2050f for lynx2.9.3.tar.bz2 matches the sha256 recorded by Homebrew, FreeBSD ports and Ravenports (the latter two also agreeing on size 2852278), so the version and checksum are right. PKG_RELEASE:=1 is correct for a version bump, and the shipped files/lynx.cfg is a 7-line minimal config rather than a copy of upstream's, so it carries no version-specific content that 2.9.3 would invalidate.
Three comments inline, none of them blocking: a question about the newly added primary mirror, a missing conffiles block that predates this PR, and a nit about an unrelated hunk.
Generated by Claude Code
| # Based on https://github.com/kyak/openwrt-packages/tree/master/lynx | ||
| # |
There was a problem hiding this comment.
nit: dropping the attribution comment is unrelated to the version bump, and with an empty commit body there is nothing recording why it went. Either keep it, or say so in the commit message so the removal is intentional on the record rather than incidental to a 2.9.2 → 2.9.3 update.
Generated by Claude Code
| PKG_SOURCE_URL:=https://invisible-mirror.net/archives/lynx/tarballs/ \ | ||
| https://fossies.org/linux/www/ | ||
| PKG_HASH:=7374b89936d991669e101f4e97f2c9592036e1e8cdaa7bafc259a77ab6fb07ce | ||
| PKG_SOURCE_URL:=https://invisible-island.net/archives/lynx/tarballs/ \ |
There was a problem hiding this comment.
Can you confirm https://invisible-island.net/archives/lynx/tarballs/lynx2.9.3.tar.bz2 actually resolves? I could not reach the host from here to check, and the evidence I can see points elsewhere: every other packaging system carrying this exact tarball fetches it from invisible-mirror.net — Homebrew Formula/l/lynx.rb and FreeBSD www/lynx-current/distinfo — while Ravenports bucket_31/lynx does use invisible-island.net but at a different path (invisible-island.net/lynx/tarballs/, with no /archives component).
Impact is low either way — a bad first entry just falls through to invisible-mirror.net on the next line — but if the path is wrong the new primary entry costs a failed round-trip on every build and buys nothing.
Generated by Claude Code
There was a problem hiding this comment.
Optional, pre-existing rather than introduced here — but a version bump is exactly when it bites, so worth folding in while you are touching the file.
The package installs two user-editable config files into /etc (Package/lynx/install, lines 68-69) but the Makefile has no define Package/lynx/conffiles block. Unregistered, the package manager treats /etc/lynx.cfg and /etc/lynx.lss as ordinary payload, so upgrading 2.9.2 → 2.9.3 silently overwrites whatever the user changed — proxy settings and charset in lynx.cfg being the obvious losses.
Adding the block near the install section fixes it:
define Package/lynx/conffiles
/etc/lynx.cfg
/etc/lynx.lss
endef
Note the lack of indentation: the block is echoed verbatim into the generated conffiles list by BuildPackVariable, so a leading tab or space ends up inside the path and the entry stops matching.
Does not block the merge.
Generated by Claude Code
Changelog: https://lynx.invisible-island.net/lynx2.9.3/CHANGES.html#index-v2.9.3 Also update source URLs in package Makefile. Signed-off-by: Leonid Esman <leonid.esman@gmail.com>
2 participants
📦 Package Details
Maintainer: @LLE8
Description: Update version to 2.9.3, update source URLs, add list of config files
🧪 Run Testing Details
✅ Formalities