Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions net/lynx/Makefile

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional, pre-existing rather than introduced here β€” but a version bump is exactly when it bites, so worth folding in while you are touching the file.

The package installs two user-editable config files into /etc (Package/lynx/install, lines 68-69) but the Makefile has no define Package/lynx/conffiles block. Unregistered, the package manager treats /etc/lynx.cfg and /etc/lynx.lss as ordinary payload, so upgrading 2.9.2 β†’ 2.9.3 silently overwrites whatever the user changed β€” proxy settings and charset in lynx.cfg being the obvious losses.

Adding the block near the install section fixes it:

define Package/lynx/conffiles
/etc/lynx.cfg
/etc/lynx.lss
endef

Note the lack of indentation: the block is echoed verbatim into the generated conffiles list by BuildPackVariable, so a leading tab or space ends up inside the path and the entry stops matching.

Does not block the merge.


Generated by Claude Code

Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
#
# This is free software, licensed under the GNU General Public License v2.
#
# Based on https://github.com/kyak/openwrt-packages/tree/master/lynx
#
Comment on lines -4 to -5

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: dropping the attribution comment is unrelated to the version bump, and with an empty commit body there is nothing recording why it went. Either keep it, or say so in the commit message so the removal is intentional on the record rather than incidental to a 2.9.2 β†’ 2.9.3 update.


Generated by Claude Code


include $(TOPDIR)/rules.mk

PKG_NAME:=lynx
PKG_VERSION:=2.9.2
PKG_VERSION:=2.9.3
PKG_RELEASE:=1

PKG_LICENSE:=GPL-2.0
PKG_MAINTAINER:=Leonid Esman <leonid.esman@gmail.com>
PKG_CPE_ID:=cpe:/a:lynx:lynx
PKG_SOURCE:=$(PKG_NAME)$(PKG_VERSION).tar.bz2
PKG_SOURCE_URL:=https://invisible-mirror.net/archives/lynx/tarballs/ \
https://fossies.org/linux/www/
PKG_HASH:=7374b89936d991669e101f4e97f2c9592036e1e8cdaa7bafc259a77ab6fb07ce
PKG_SOURCE_URL:=https://invisible-island.net/archives/lynx/tarballs/ \

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm https://invisible-island.net/archives/lynx/tarballs/lynx2.9.3.tar.bz2 actually resolves? I could not reach the host from here to check, and the evidence I can see points elsewhere: every other packaging system carrying this exact tarball fetches it from invisible-mirror.net β€” Homebrew Formula/l/lynx.rb and FreeBSD www/lynx-current/distinfo β€” while Ravenports bucket_31/lynx does use invisible-island.net but at a different path (invisible-island.net/lynx/tarballs/, with no /archives component).

Impact is low either way β€” a bad first entry just falls through to invisible-mirror.net on the next line β€” but if the path is wrong the new primary entry costs a failed round-trip on every build and buys nothing.


Generated by Claude Code

https://invisible-mirror.net/archives/lynx/tarballs/ \
https://fossies.org/linux/www/ \
https://ftp2.osuosl.org/pub/blfs/conglomeration/lynx/
PKG_HASH:=174b7f2866a60f3247ba75f5c7dbb10b124aede4a1359312de15f3bfebd2050f
PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME)$(PKG_VERSION)

include $(INCLUDE_DIR)/package.mk
Expand Down