docs + htcondor fix#130
Merged
Merged
Conversation
Owner
oshaughn
commented
May 11, 2026
oshaughn
commented
- htcondor2 engine: was not correctly quoting argument strings, so it broke some behavior.
- docs: more documentation project (asimov; calmarg; 'physics') and critically the simulation_manager design page
added 5 commits
May 8, 2026 21:48
The HTCondorBackend in dag_utils_generic.py was emitting
arguments = <joined args>
with no outer quoting, putting condor_submit into its old
arguments-syntax mode. That changed how brackets, commas, and
embedded single-quoted tokens are parsed (e.g. '[0.2,0.2499]'
reached the executable as a different argv string) relative to
the original glue.pipeline implementation, whose write_sub_file
wraps the join in double quotes (new arguments syntax).
Wrap the joined argument string in double quotes in
HTCondorBackend._build_submit_dict so both the htcondor.Submit
render path and the text fallback emit
arguments = "<joined args>"
exactly matching glue's behavior. Idempotent: if the caller
already wrapped the string, we don't double-wrap. Slurm is
unaffected because the wrap lives at the HTCondor-specific seam
rather than in the shared _build_argument_string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.