fix: make domain name resolution async - #1642
Open
citizen-stig wants to merge 3 commits into
Open
Conversation
bkolad
approved these changes
Jun 9, 2026
citizen-stig
changed the title
Contributor
Author
citizen-stig
changed the title
citizen-stig
force-pushed
the
nikolai/async-name-resonlution
branch
from
July 30, 2026 07:12
a138a08 to
ccacde4
Compare
Contributor
Author
|
@DenzelPenzel I also would like to bump this PR |
| // internally, so IP literals and default ports behave exactly as before. | ||
| match uri.host() { | ||
| Some(url::Host::Domain(domain)) => { | ||
| tokio::net::lookup_host((domain, port)).await.map(|addrs| addrs.collect()).map_err(|e| { |
Contributor
There was a problem hiding this comment.
timeout stops waiting for lookup_host, but it does not cancel the underlying spawn_blocking DNS lookup. wdty?
Contributor
Author
There was a problem hiding this comment.
That's true, but I don't know how it can addressed.
But current approach makes situation a little better than on main, because on main broken resolver will stall whole runtime, while here we will have task sitting on blocking pool thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So faulty resovler won't starve runtime.
try_connect_over_tcp resolved DNS with uri.socket_addrs(|| None) (initial connect and redirect) → std::net::ToSocketAddrs → blocking getaddrinfo on the current Tokio worker thread, outside the timeout. The connection_timeout only ever wrapped TcpStream::connect (inside connect() via tokio::select!).
Include resolution into timeout