Skip to content

feat: add support for connection_timeout - #1643

Merged
lexnv merged 4 commits into
paritytech:masterfrom
citizen-stig:nikolai/add-connect-timeout
Jul 31, 2026
Merged

feat: add support for connection_timeout#1643
lexnv merged 4 commits into
paritytech:masterfrom
citizen-stig:nikolai/add-connect-timeout

Conversation

@citizen-stig

Copy link
Copy Markdown
Contributor

So down server can be detected sooner and can be distinguish from slow server

@niklasad1

niklasad1 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@lexnv can you or someone at parity take a look at this PR and #1642 when you have time?

Both looks straightforward to me, #1642 makes the DNS resolution async instead of blocking.

@citizen-stig

Copy link
Copy Markdown
Contributor Author

Hey @lexnv , thanks for the quick review! Would be great to have a second review too.

I've fixed formatting. Failed tests look unrelated, this seams to be the root cause

Root cause: serde 1.0.228 split core traits into the new serde_core crate, which changed rustc's diagnostic text. The committed snapshot proc-macros/tests/ui/incorrect/rpc/rpc_empty_bounds.stderr:5 expects the trait for<'de> Deserialize<'de> is not implemented but rustc now emits the trait for<'de> serde_core::de::Deserialize<'de> is not implemented. That one line is the only difference (verified by diffing EXPECTED vs ACTUAL in the CI log).

Please let me know if anything else needs to be done to get this merged

@niklasad1

Copy link
Copy Markdown
Contributor

Please let me know if anything else needs to be done to get this merged

It's unrelated to this PR, most likely the UI tests changed slightly because of a rustc toolchain update.

Either just fix the UI tests in this PR or a separate PR, should just be to update tests/ui/incorrect/rpc/rpc_empty_bounds.rs no big deal really.

@citizen-stig citizen-stig changed the title Add support for connection_timeout feat: add support for connection_timeout Jun 12, 2026
Comment thread client/http-client/src/transport.rs
@citizen-stig
citizen-stig force-pushed the nikolai/add-connect-timeout branch from 5ff731f to 6886284 Compare July 30, 2026 07:12
@citizen-stig

Copy link
Copy Markdown
Contributor Author

Hey @DenzelPenzel , thanks for the quick review!
What needs to happen for this PR to be merged?

@lexnv
lexnv merged commit 9a4d78d into paritytech:master Jul 31, 2026
3 checks passed
@idiibrahimggabal41-afk

Copy link
Copy Markdown

Dig nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants