[Method Browser] Fix method list desync when filter is active during method announcements#1388
Merged
Ducasse merged 3 commits intopharo-spec:Pharo14from Apr 23, 2026
Merged
Conversation
added 2 commits
April 17, 2026 10:30
…ethod announcements `handleMethodAdded:` and `handleMethodModified:` were operating on the filtered list (self methods) instead of the unfilteredItems, causing methods outside the current filter to be silently dropped when a code change was announced. Fixed by always reading/writing through unfilteredItems and working on a copy before calling self methods:. Also fixed: - duplicate selectedIndex assignment in handleMethodRemoved: - windowTitle now shows 'No results' when the list is empty - cleaning code comment and protocol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleMethodAdded:andhandleMethodModified:were operating on the filtered list (self methods) instead of the unfilteredItems, causing methods outside the current filter to be silently dropped when a code change was announced.Fixed by always reading/writing through unfilteredItems and working on a copy before calling self methods:
And of course new test to deny regression on this behavior
Also fixed: