Skip to content

save: reject docker transport image references - #29317

Open
Rajkaran-122 wants to merge 2 commits into
podman-container-tools:mainfrom
Rajkaran-122:fix-save-docker-transport-error
Open

save: reject docker transport image references#29317
Rajkaran-122 wants to merge 2 commits into
podman-container-tools:mainfrom
Rajkaran-122:fix-save-docker-transport-error

Conversation

@Rajkaran-122

@Rajkaran-122 Rajkaran-122 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Checklist

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all commits (git commit -s).
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated
  • All commits pass make validatepr
  • Release note entered below (or no user-facing changes)

Does this PR introduce a user-facing change?

No

When `podman save` is invoked with `docker://{image}`, a more appropriate error is now returned.

@TomSweeneyRedHat

Copy link
Copy Markdown
Contributor

LGTM
@Rajkaran-122 TYVM. If you're feeling energetic, similar changes could most likely occur for rmi, inspect, and maybe other commands.

@Rajkaran-122

Copy link
Copy Markdown
Contributor Author

LGTM @Rajkaran-122 TYVM. If you're feeling energetic, similar changes could most likely occur for rmi, inspect, and maybe other commands.

Thank you for the review and the helpful suggestion! I'll investigate whether similar validation can be applied to rmi, inspect, and other commands.

@Rajkaran-122

Rajkaran-122 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Thanks again @TomSweeneyRedHat sir for the suggestion. I opened follow-up PRs for rmi and inspect implementing similar validation:

#29332 (rmi)
#29334 (inspect)

@Luap99 Luap99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#29334 (review)

same as on the other PRs

@Rajkaran-122

Rajkaran-122 commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review @Luap99 @TomSweeneyRedHat . Following the feedback, I moved the discussion to the shared backend implementation in podman-container-tools/container-libs#1044 instead of continuing with command-specific validation here. I'll update this PR based on the outcome there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants