Skip to content

save: reject docker transport image references #29317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rajkaran-122 wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −0
Open

save: reject docker transport image references #29317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49242e9
save: reject docker transport image references
Rajkaran-122 Jul 28, 2026
91f4202
Merge branch 'podman-container-tools:main' into fix-save-docker-trans…
Rajkaran-122 Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/podman/images/save.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ func save(cmd *cobra.Command, args []string) (finalErr error) {
tags []string
succeeded = false
)
if strings.HasPrefix(args[0], "docker://") {
return fmt.Errorf("image %q is not in local storage; remove the docker:// prefix", args[0])
}
if cmd.Flag("compress").Changed && saveOpts.Format != define.V2s2ManifestDir {
return errors.New("--compress can only be set when --format is 'docker-dir'")
}
Expand Down
6 changes: 6 additions & 0 deletions test/e2e/save_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ var _ = Describe("Podman save", func() {
Expect(save).To(ExitWithError(125, "repository name must be lowercase"))
})

It("podman save rejects docker transport", func() {
save := podmanTest.Podman([]string{"save", "-q", "docker://" + ALPINE})
save.WaitWithDefaultTimeout()
Expect(save).To(ExitWithError(125, "is not in local storage; remove the docker:// prefix"))
})

It("podman save to directory with oci format", func() {
outdir := filepath.Join(podmanTest.TempDir, "save")

Expand Down