hack/ci: exit instead of return on missing github credentials - #29531
Open
ROKUMATE wants to merge 1 commit into
Open
hack/ci: exit instead of return on missing github credentials#29531ROKUMATE wants to merge 1 commit into
ROKUMATE wants to merge 1 commit into
Conversation
ROKUMATE
force-pushed
the
hack-ci-pr-tests-exit
branch
from
August 17, 2026 11:04
e2f8312 to
a526920
Compare
Signed-off-by: ROKUMATE <rohitkumawat0110@gmail.com>
ROKUMATE
force-pushed
the
hack-ci-pr-tests-exit
branch
from
August 17, 2026 11:11
a526920 to
4637153
Compare
Honny1
reviewed
Aug 17, 2026
Luap99
reviewed
Aug 17, 2026
| for var in GITHUB_TOKEN GITHUB_REPOSITORY; do | ||
| if [[ -z "${!var}" ]]; then | ||
| echo "$ME: cannot query github: \$$var is undefined" >&2 | ||
| return 1 |
Member
There was a problem hiding this comment.
why not just turn this into exit 1?
This gave a reasonable error message, with the change now we get the full no tests message if GITHUB_TOKEN/GITHUB_REPOSITORY is missing from the env which will be confusing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr-should-include-tests is executed, not sourced, so the
return 1used when GITHUB_TOKEN or GITHUB_REPOSITORY is unset does not stop the script. bash printsreturn: can only return from a function or sourced scriptand execution falls through to the curl call with empty credentials, ultimately failing with the misleadingPR does not include testsmessage instead of the intendedcannot query githuberror.Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?