Skip to content

hack/ci: exit instead of return on missing github credentials #29531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Luap99 merged 1 commit into from
Aug 19, 2026
+7 −1
Merged

hack/ci: exit instead of return on missing github credentials #29531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hack/ci/pr-should-include-tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ if [[ -n "$PR_NUMBER" ]]; then
for var in GITHUB_TOKEN GITHUB_REPOSITORY; do
if [[ -z "${!var}" ]]; then
echo "$ME: cannot query github: \$$var is undefined" >&2
return 1
Comment thread
ROKUMATE marked this conversation as resolved.
exit 1
fi
done

Expand Down
6 changes: 6 additions & 0 deletions hack/ci/pr-should-include-tests.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,12 @@ function run_test_script() {
rc=0
testnum=0

# This harness may run in CI, where PR_NUMBER is set in the environment. The
# cases below only exercise the local git-diff logic, not the github override-
# label lookup (which needs real credentials), so ensure the script under test
# never enters that path.
unset PR_NUMBER

while read expected_rc parent_sha commit_sha pr rest; do
# Skip blank lines
test -z "$expected_rc" && continue
Expand Down