feat(RebarTranslator): apply white color to item names if not set#742
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Rebar’s server-side item translation pipeline to ensure translated item display names default to white when no explicit color is set, addressing Issue #741 and allowing <white> to be removed from language files.
Changes:
- Apply
NamedTextColor.WHITEto translatedITEM_NAMEcomponents when the rendered component has no color set. - Refactor the
ITEM_NAMEtranslation block to compute an intermediateresultcomponent before final styling is applied.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I think you forgot to push pylon branch |
|
I changed pylon language file on my test server directly. If you want I will create pylon PR. |
|
yeah, that would be good |
|
Why not just wrap it in a root component that is white, like lore does for light gray? |
lore needs to handle italic style, but name doesn't |
|
I'd much rather have a solution that's redundant 90% of the time but is simple to understand and maintain than extracting the color or whatever |
I really don't think it matters, honestly what's here seems simpler than the alternative which indicates to me it's just a matter of taste / what you're used to, also it's a 1-line addition and that file has FAR less readable things than this XD |
Fixes #741
After fix, removed

<white>from item name:Also I changed the

Liselette Collectorto<lang:pylon.item.liselette_collector.name/>: