Skip to content

feat(RebarTranslator): apply white color to item names if not set #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LordIdra merged 1 commit into from
May 17, 2026
+5 −2
Merged

feat(RebarTranslator): apply white color to item names if not set #742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions rebar/src/main/kotlin/io/github/pylonmc/rebar/i18n/RebarTranslator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import io.papermc.paper.datacomponent.item.ItemLore
import io.papermc.paper.datacomponent.item.ResolvableProfile
import net.kyori.adventure.key.Key
import net.kyori.adventure.text.*
import net.kyori.adventure.text.format.NamedTextColor
import net.kyori.adventure.text.format.Style
import net.kyori.adventure.translation.GlobalTranslator
import net.kyori.adventure.translation.Translator
Expand Down Expand Up @@ -218,12 +219,14 @@ class RebarTranslator private constructor(private val addon: RebarAddon) : Trans
}

val translated = GlobalTranslator.render(it.withArguments(concatenatedArguments), locale)
if (translated is TranslatableComponent && translated.fallback() != null) {
val result = if (translated is TranslatableComponent && translated.fallback() != null) {
Component.text(translated.fallback()!!)
Comment thread
ybw0014 marked this conversation as resolved.
} else {
translated
}

// apply white color if not set
if (result.style().color() == null) result.color(NamedTextColor.WHITE) else result
}
editData(DataComponentTypes.LORE) { lore ->
val newLore = lore.lines().flatMap { line ->
Expand Down Expand Up @@ -284,4 +287,4 @@ class RebarTranslator private constructor(private val addon: RebarAddon) : Trans

private val Material.isPotion: Boolean
get() = this == Material.POTION || this == Material.SPLASH_POTION ||
this == Material.LINGERING_POTION || this == Material.TIPPED_ARROW
this == Material.LINGERING_POTION || this == Material.TIPPED_ARROW
Loading