Avoid version set construction in get applicable candidates#13916
Merged
notatallshaw merged 2 commits intopypa:mainfrom Apr 17, 2026
Merged
Conversation
Member
Author
|
P.S, I think there's a very subtle bug, and further performance wins, in |
sbidoul
approved these changes
Apr 17, 2026
Member
sbidoul
left a comment
sbidoul
left a comment
There was a problem hiding this comment.
Even if this does not improve performance significantly, this is easier to read 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packaging 26.1 adds a new
keyparameter on their filter methods, this allows a packaging specifier to directly filter candidate objects without needing to do any pre-work or construct a set of versions, which can be a hot spot of working during long resolutions.I'm not sure what the real world performance impact will be, because constructing and retrieving the hash of a version also got a lot faster in 26.1: pypa/packaging#1156 (comment), but either way it's work we no longer needed to be doing.