Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/13916.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Minor performance improvement when filtering candidates during resolution.
26 changes: 10 additions & 16 deletions src/pip/_internal/index/package_finder.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from pip._vendor.packaging import specifiers
from pip._vendor.packaging.tags import Tag
from pip._vendor.packaging.utils import NormalizedName, canonicalize_name
from pip._vendor.packaging.version import InvalidVersion, Version, _BaseVersion
from pip._vendor.packaging.version import InvalidVersion, _BaseVersion
from pip._vendor.packaging.version import parse as parse_version

from pip._internal.exceptions import (
Expand Down Expand Up @@ -493,30 +493,24 @@ def get_applicable_candidates(
else:
allow_prereleases = None
specifier = self._specifier

# When using the pkg_resources backend we turn the version object into
# a str here because otherwise when we're debundled but setuptools isn't,
# Python will see packaging.version.Version and
# pkg_resources._vendor.packaging.version.Version as different
# types. This way we'll use a str as a common data interchange
# format. If we stop using the pkg_resources provided specifier
# and start using our own, we can drop the cast to str().
if select_backend().NAME == "pkg_resources":
candidates_and_versions: list[
tuple[InstallationCandidate, str | Version]
] = [(c, str(c.version)) for c in candidates]
else:
candidates_and_versions = [(c, c.version) for c in candidates]
versions = set(
specifier.filter(
(v for _, v in candidates_and_versions),
prereleases=allow_prereleases,
)
applicable_candidates = specifier.filter(
candidates,
prereleases=allow_prereleases,
key=lambda c: (
str(c.version)
if select_backend().NAME == "pkg_resources"
else c.version
),
)

applicable_candidates = [c for c, v in candidates_and_versions if v in versions]
filtered_applicable_candidates = filter_unallowed_hashes(
candidates=applicable_candidates,
candidates=list(applicable_candidates),
hashes=self._hashes,
project_name=self._project_name,
)
Expand Down