-
Notifications
You must be signed in to change notification settings - Fork 235
QCLINUX: arm64: dts: qcom: lemans and monaco: Rework RTSS Mailbox DT to use syscon and staging overlays #1768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sargarram7
wants to merge
7
commits into
qualcomm-linux:tech/overlay/dt
Choose a base branch
from
sargarram7:feature/rtss-topic-dt
base: tech/overlay/dt
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cf357d5
Revert "QCLINUX: arm64: dts: qcom: lemans: Add RTSS Mailbox device tr…
sargarram7 d99e8d6
Revert "QCLINUX: arm64: dts: qcom: Monaco: Add RTSS Mailbox device tr…
sargarram7 e26d1ac
arm64: dts: qcom: lemans: Add IPCC and syscon nodes for RTSS Mailbox
sargarram7 931186f
arm64: dts: qcom: lemans-staging: Add rtss-mailbox node
sargarram7 4ecfab3
arm64: dts: qcom: monaco: Add IPCC, syscon, and reserved-memory nodes…
sargarram7 7543ed2
arm64: dts: qcom: monaco-staging: Add rtss-mailbox node
sargarram7 8bffa16
dt-bindings: mailbox: Add qcom,rtss-mailbox schema
sargarram7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
99 changes: 99 additions & 0 deletions
99
Documentation/devicetree/bindings/mailbox/qcom,rtss-mailbox.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| # SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause | ||
| %YAML 1.2 | ||
| --- | ||
| $id: http://devicetree.org/schemas/mailbox/qcom,rtss-mailbox.yaml# | ||
| $schema: http://devicetree.org/meta-schemas/core.yaml# | ||
|
|
||
| title: Qualcomm Technologies, Inc. RTSS Mailbox | ||
|
|
||
| maintainers: | ||
| - Ram Sargar <rsargar@qti.qualcomm.com> | ||
|
|
||
| description: | ||
| The RTSS mailbox exposes a shared-memory and IPCC doorbell channel between | ||
| the application processor and the RTSS subsystem, and manages handshake | ||
| with the RTSS subsystem to handle different milestones in mission mode. | ||
|
|
||
| properties: | ||
| compatible: | ||
| items: | ||
| - enum: | ||
| - qcom,sa8775p-rtss-mailbox | ||
| - qcom,qcs8300-rtss-mailbox | ||
| - const: qcom,rtss-mailbox | ||
|
|
||
| qcom,syscon-tcsr-req: | ||
| $ref: /schemas/types.yaml#/definitions/phandle-array | ||
| items: | ||
| - items: | ||
| - description: phandle to the TCSR syscon node | ||
| - description: offset of the RTSS request register from the syscon base | ||
| description: | ||
| Reference to the TCSR syscon node and register offset used to write | ||
| the boot/suspend handshake magic that RTSS reads. | ||
|
|
||
| qcom,syscon-tcsr-resp: | ||
| $ref: /schemas/types.yaml#/definitions/phandle-array | ||
| items: | ||
| - items: | ||
| - description: phandle to the TCSR syscon node | ||
| - description: offset of the RTSS response register from the syscon base | ||
| description: | ||
| Reference to the TCSR syscon node and register offset used to read | ||
| back the handshake magic RTSS acknowledges with. | ||
|
|
||
| qcom,syscon-ipc: | ||
| $ref: /schemas/types.yaml#/definitions/phandle-array | ||
| items: | ||
| - items: | ||
| - description: phandle to the APSS shared IPC syscon node | ||
| - description: offset of the IPC trigger register from the syscon base | ||
| description: | ||
| Reference to the syscon node and register offset used to trigger the | ||
| IPC interrupt that notifies RTSS a TCSR handshake register was updated. | ||
|
|
||
| mboxes: | ||
| description: | ||
| IPCC mailbox channels used to send interrupts to the RTSS-facing IPCC | ||
| client/signal pairs. | ||
|
|
||
| interrupts-extended: | ||
| description: | ||
| IPCC channels used to receive interrupts from the RTSS-facing IPCC | ||
| client/signal pairs. | ||
|
|
||
| memory-region: | ||
| items: | ||
| - description: reserved-memory carveout for the RTSS mailbox descriptor region | ||
| - description: reserved-memory carveout for the OTA region | ||
| description: | ||
| Reference to the reserved-memory regions used for the mailbox | ||
| descriptor and for OTA. | ||
|
|
||
| required: | ||
| - compatible | ||
| - qcom,syscon-tcsr-req | ||
| - qcom,syscon-tcsr-resp | ||
| - qcom,syscon-ipc | ||
| - mboxes | ||
| - interrupts-extended | ||
| - memory-region | ||
|
|
||
| additionalProperties: false | ||
|
|
||
| examples: | ||
| - | | ||
| #include <dt-bindings/interrupt-controller/irq.h> | ||
| #include <dt-bindings/mailbox/qcom-ipcc.h> | ||
|
|
||
| rtss-ipcc-mailbox { | ||
| compatible = "qcom,sa8775p-rtss-mailbox", "qcom,rtss-mailbox"; | ||
| qcom,syscon-tcsr-req = <&tcsr 0x3e02c>; | ||
| qcom,syscon-tcsr-resp = <&tcsr 0x3d018>; | ||
| qcom,syscon-ipc = <&apss_shared_ipc 0x0>; | ||
| mboxes = <&ipcc1 IPCC_CLIENT_RTSS0 0x2>, | ||
| <&ipcc1 IPCC_CLIENT_RTSS1 0x3>; | ||
| interrupts-extended = <&ipcc1 IPCC_CLIENT_RTSS0 0x2 IRQ_TYPE_EDGE_RISING>, | ||
| <&ipcc1 IPCC_CLIENT_RTSS1 0x3 IRQ_TYPE_EDGE_RISING>; | ||
| memory-region = <&sail_mailbox_mem>, <&sail_ota_mem>; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1018,6 +1018,42 @@ | |
| #mbox-cells = <2>; | ||
| }; | ||
|
|
||
| ipcc1: mailbox@488000 { | ||
| compatible = "qcom,sa8775p-ipcc", "qcom,ipcc"; | ||
| reg = <0x0 0x00488000 0x0 0x1000>; | ||
| interrupts = <GIC_SPI 231 IRQ_TYPE_LEVEL_HIGH>; | ||
| interrupt-controller; | ||
| #interrupt-cells = <3>; | ||
| #mbox-cells = <2>; | ||
| }; | ||
|
|
||
| ipcc2: mailbox@4a1000 { | ||
| compatible = "qcom,sa8775p-ipcc", "qcom,ipcc"; | ||
| reg = <0x0 0x004a1000 0x0 0x1000>; | ||
| interrupts = <GIC_SPI 553 IRQ_TYPE_LEVEL_HIGH>; | ||
| interrupt-controller; | ||
| #interrupt-cells = <3>; | ||
| #mbox-cells = <2>; | ||
| }; | ||
|
|
||
| ipcc3: mailbox@4a2000 { | ||
| compatible = "qcom,sa8775p-ipcc", "qcom,ipcc"; | ||
| reg = <0x0 0x004a2000 0x0 0x1000>; | ||
| interrupts = <GIC_SPI 554 IRQ_TYPE_LEVEL_HIGH>; | ||
| interrupt-controller; | ||
| #interrupt-cells = <3>; | ||
| #mbox-cells = <2>; | ||
| }; | ||
|
|
||
| ipcc4: mailbox@4a3000 { | ||
| compatible = "qcom,sa8775p-ipcc", "qcom,ipcc"; | ||
| reg = <0x0 0x004a3000 0x0 0x1000>; | ||
| interrupts = <GIC_SPI 555 IRQ_TYPE_LEVEL_HIGH>; | ||
| interrupt-controller; | ||
| #interrupt-cells = <3>; | ||
| #mbox-cells = <2>; | ||
| }; | ||
|
|
||
| qfprom: efuse@784000 { | ||
| compatible = "qcom,sa8775p-qfprom", "qcom,qfprom"; | ||
| reg = <0x0 0x00784000 0x0 0x3000>; | ||
|
|
@@ -4635,7 +4671,7 @@ | |
|
|
||
| tcsr: syscon@1fc0000 { | ||
| compatible = "qcom,sa8775p-tcsr", "syscon"; | ||
| reg = <0x0 0x1fc0000 0x0 0x30000>; | ||
| reg = <0x0 0x1fc0000 0x0 0x40000>; | ||
| }; | ||
|
|
||
| gpu: gpu@3d00000 { | ||
|
|
@@ -7058,6 +7094,11 @@ | |
| redistributor-stride = <0x0 0x20000>; | ||
| }; | ||
|
|
||
| apss_shared_ipc: syscon@17c0000c { | ||
| compatible = "qcom,sa8775p-tcsr", "syscon"; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What exactly is behind this address? TCSR is at the other address, so it can't be TCSR. |
||
| reg = <0x0 0x17c0000c 0x0 0x4>; | ||
| }; | ||
|
|
||
| watchdog@17c10000 { | ||
| compatible = "qcom,apss-wdt-sa8775p", "qcom,kpss-wdt"; | ||
| reg = <0x0 0x17c10000 0x0 0x1000>; | ||
|
|
||
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are not.