fix(lambda): rate-limit retry warn log to avoid log storms#6318
Merged
trinity-1686a merged 6 commits intomainfrom May 5, 2026
Merged
fix(lambda): rate-limit retry warn log to avoid log storms#6318trinity-1686a merged 6 commits intomainfrom
trinity-1686a merged 6 commits intomainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
trinity-1686a
approved these changes
Apr 20, 2026
When the rate limiter opens a new window after suppressing messages, it now emits a preceding log at the same level: "suppressed N similar log messages in the last minute" Closes #6322. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… enum The three possible outcomes (log normally, log after suppression, suppress) are now distinct enum variants, removing the implicit invariant that the skipped count is only meaningful when the bool is true. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
trinity-1686a
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WARNlog on every attempt. Under heavy rate-limiting this floods customer logs, 700k+ logs was observed.quickwit_common::rate_limited_warn!(limit_per_min = 10, ...)so at most 10 warnings are emitted per minute regardless of retry volume.Test plan
cargo check -p quickwit-lambda-clientpasses🤖 Generated with Claude Code