Skip to content

fix(lambda): rate-limit retry warn log to avoid log storms #6318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trinity-1686a merged 6 commits into from
May 5, 2026
+65 −31
Merged

fix(lambda): rate-limit retry warn log to avoid log storms #6318

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
78ba842
fix(lambda): rate-limit retry warn log to avoid log storms
fmassot Apr 19, 2026
e6c5ce4
Merge branch 'main' into fmassot/rate-limit-lambda-retry-warn
fmassot Apr 21, 2026
62036e8
feat(rate-limited-log): report suppressed message count on period reset
fmassot Apr 22, 2026
e30ade8
refactor(rate-limited-log): replace (bool, u32) return with ShouldLog…
fmassot Apr 23, 2026
eab2a9e
rustfmt
trinity-1686a May 5, 2026
f5bd69a
Merge branch 'main' into fmassot/rate-limit-lambda-retry-warn
trinity-1686a May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions quickwit/quickwit-lambda-client/src/invoker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ use quickwit_common::retry::RetryParams;
use quickwit_lambda_server::{LambdaSearchRequestPayload, LambdaSearchResponsePayload};
use quickwit_proto::search::{LambdaSearchResponses, LambdaSingleSplitResult, LeafSearchRequest};
use quickwit_search::{LambdaLeafSearchInvoker, SearchError};
use tracing::{debug, info, instrument, warn};
use tracing::{debug, info, instrument};

use crate::metrics::LAMBDA_METRICS;

Expand Down Expand Up @@ -203,7 +203,8 @@ impl AwsLambdaInvoker {
LambdaInvokeError::Permanent(_) => return Err(error.into_search_error()),
};

warn!(
quickwit_common::rate_limited_warn!(
limit_per_min = 10,
num_attempts = num_attempts,
delay_ms = delay.as_millis(),
"lambda invocation failed, retrying"
Expand Down
Loading