Critical Bug Fix: Keyboard listeners for range slider#510
Open
M-Izadmehr wants to merge 1 commit intoreact-component:masterfrom
Open
Critical Bug Fix: Keyboard listeners for range slider#510M-Izadmehr wants to merge 1 commit intoreact-component:masterfrom
M-Izadmehr wants to merge 1 commit intoreact-component:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #510 +/- ##
=======================================
Coverage 83.36% 83.36%
=======================================
Files 10 10
Lines 463 463
Branches 120 121 +1
=======================================
Hits 386 386
Misses 77 77
Continue to review full report at Codecov.
|
|
When this fix is going to be merged? |
Contributor
Contributor
Member
|
Rebase please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



In the range slider , the currentHandle parameter is not determined correctly when using the keyboard to move the handles.
As a result, when using range-slider by keyboard (e.g. arrow keys) the whole component crashes.
I made a quick fix to use the recent handle if the current handle is not found.