Skip to content

Critical Bug Fix: Keyboard listeners for range slider#510

Open
M-Izadmehr wants to merge 1 commit intoreact-component:masterfrom
M-Izadmehr:bug-fix-keyboard-range
Open

Critical Bug Fix: Keyboard listeners for range slider#510
M-Izadmehr wants to merge 1 commit intoreact-component:masterfrom
M-Izadmehr:bug-fix-keyboard-range

Conversation

@M-Izadmehr
Copy link
Copy Markdown
Contributor

@M-Izadmehr M-Izadmehr commented Dec 27, 2018

In the range slider , the currentHandle parameter is not determined correctly when using the keyboard to move the handles.
As a result, when using range-slider by keyboard (e.g. arrow keys) the whole component crashes.
I made a quick fix to use the recent handle if the current handle is not found.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 27, 2018

Codecov Report

Merging #510 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #510   +/-   ##
=======================================
  Coverage   83.36%   83.36%           
=======================================
  Files          10       10           
  Lines         463      463           
  Branches      120      121    +1     
=======================================
  Hits          386      386           
  Misses         77       77
Impacted Files Coverage Δ
src/Range.jsx 60.13% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cdc5c4...4392fe8. Read the comment docs.

@GiselaMD
Copy link
Copy Markdown

When this fix is going to be merged?

@ztplz
Copy link
Copy Markdown
Contributor

ztplz commented Feb 21, 2019

image
It will still crash.
image
state.handle => state.handle || state.recent

@ztplz
Copy link
Copy Markdown
Contributor

ztplz commented Feb 21, 2019

But I found a new problem.
untitled7
I think the original logic should be fixed.

@yoyo837
Copy link
Copy Markdown
Member

yoyo837 commented Apr 15, 2023

Rebase please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants