Allow retrieving dataset top-level field names#21956
Merged
dpiparo merged 2 commits intoroot-project:masterfrom Apr 22, 2026
Merged
Allow retrieving dataset top-level field names#21956dpiparo merged 2 commits intoroot-project:masterfrom
dpiparo merged 2 commits intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 13h 1m 51s ⏱️ Results for commit b5c100d. ♻️ This comment has been updated with latest results. |
Member
|
Is this PR fixing #18733 ? |
Member
Author
vepadulano
force-pushed
the
rdf-expose-toplevel-field-names
branch
2 times, most recently
from
564f6cc to
0e22c5f
Compare
vepadulano
force-pushed
the
rdf-expose-toplevel-field-names
branch
from
0e22c5f to
aecacda
Compare
Member
Author
|
@dpiparo this should go to 6.40 |
Useful for instance when calling Snapshot and wanting to select only top-level field names, possibly further filtering the list (e.g. through regexes).
Enabling the GetTopLevelFieldNames method in RNTuple exposed one previously faulty interaction between this and Snapshot. For the case of Snapshot with a regex, the regex would only consider top-level column names. If the regex contains a specific name of a subfield, e.g. "columnName.dataMember", then the regex would fail even though that column exists in the dataset. This commit also keeps the default Snapshot behaviour of only considering the top-level column names, but checks for the full list of column names in case a regex failed before throwing the final error if necessary.
vepadulano
force-pushed
the
rdf-expose-toplevel-field-names
branch
from
aecacda to
b5c100d
Compare
Member
|
/backport to 6.38, 6.36 |
Member
|
/backport to 6.38, 6.36 |
dpiparo
added
in:RDataFrame
clean build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful for instance when calling Snapshot and wanting to select only top-level field names, possibly further filtering the list (e.g. through regexes).
Personal note: I believe that having
GetColumnNames,GetDefinedColumnNames,GetColumnTypewas already showing a pattern, now with this new one we are clearly lacking a general-purpose API to inspect the dataset schema description. I wouldn't introduce it in this PR because it needs further thinkingFYI @TomasDado