feat: Add toolbar_download_button()#1298

Open

elnelson575 wants to merge 49 commits into

mainfrom

feat/toolbar-download-button

Commits on May 29, 2026

Add design spec for toolbar_download_button()

elnelson575
and
claude
committed
feat: Add toolbar_download_button() R functions

elnelson575
and
claude
committed
feat: Add TypeScript binding for toolbar_download_button

elnelson575
and
claude
committed
feat: Add SCSS styles for toolbar_download_button

elnelson575
and
claude
committed
test: Add tests for toolbar_download_button

elnelson575
and
claude
committed
`air format` (GitHub Actions)
elnelson575
committed
`devtools::document()` (GitHub Actions)
elnelson575
committed
Resave distributed files (GitHub Action)
elnelson575
committed
Resave data (GitHub Action)
elnelson575
committed
Address PR review feedback

elnelson575
and
claude
committed
Use custom message handler instead of InputBinding for download button

elnelson575
and
claude
committed
feat: expand toolbarDownloadButton message handler to support label, icon, showLabel

elnelson575
and
claude
committed
fix: correct imports, add null guards, use hasDefinedProperty in toolbarDownloadButton
elnelson575
committed
fix: gate toolbar download button hover/focus behind btn-default to respect variant classes
elnelson575
committed
test: add failing tests for toolbar_download_button() enabled param

elnelson575
and
claude
committed
feat: wrap shiny::downloadButton() and replace disabled with tristate enabled param

elnelson575
and
claude
committed
fix: use dev shiny downloadButton(enabled=) directly, remove post-processing workaround
elnelson575
committed
feat: expand update_toolbar_download_button() with label, icon, show_label params
elnelson575
committed
chore: rebuild components and regenerate docs
elnelson575
committed
test: update toolbar_download_button() snapshots for enabled param
elnelson575
committed
docs: rewrite download-button demo for three enabled modes
elnelson575
committed
fix: align with Shiny PR #4371 — rename data-ignore-update to data-shiny-disable-auto-enable

elnelson575
and
claude
committed
feat: warn on invalid enabled values in toolbar_download_button()

elnelson575
and
claude
committed
Updated to add commented gate + tests
elnelson575
committed
chore: remove download-button design doc and autoenable demo
elnelson575
committed
feat: add toolbar_download_button with class support and fix hover styles
elnelson575
committed
refactor: address PR review comments on toolbar_download_button
elnelson575
committed
refactor: replace toolbar SCSS mixin with explicit shared selector block
elnelson575
committed
fix: align toolbar_download_button border class with toolbar_input_button
elnelson575
committed
chore: commit compiled JS dist for toolbarDownloadButton.ts changes
elnelson575
committed
docs: explain why action-label/action-icon wrappers are built manually
elnelson575
committed
docs: clarify LibSass comment and note download-button color overrides location
elnelson575
committed
refactor: simplify shared toolbar button styles to plain combined selector
elnelson575
committed
refactor: consolidate shared toolbar button layout and interaction styles
elnelson575
committed
fix: restore text-decoration suppression for all download button variants
elnelson575
committed
test: toolbar test review — fix false-green, add 5 uncovered paths, tighten class check
elnelson575
committed
docs: use @inheritParams for toolbar_download_button, expand example with shinyApp + downloadHandler
elnelson575
committed
fix: guard label_text check with !is.null(label) in update functions; align comments
elnelson575
committed
docs: remove renderUI note from enabled param — general Shiny behavior, not specific here
elnelson575
committed
chore: restore height comment in toolbar button block
elnelson575
committed
chore: expand hover/active rules, clarify color comment in toolbar button block
elnelson575
committed
chore: recompile CSS after rebase on main
elnelson575
committed
test: clarify show_label test comment re: icon default
elnelson575
committed
fix: update_toolbar_download_button() and test cleanup
elnelson575
committed
docs: inheritParams for update_toolbar_download_button
elnelson575
committed
`air format` (GitHub Actions)
elnelson575
committed
`devtools::document()` (GitHub Actions)
elnelson575
committed
`yarn build` (GitHub Actions)
elnelson575
committed
Resave data (GitHub Action)
elnelson575
committed