-
Notifications
You must be signed in to change notification settings - Fork 66
feat: Add toolbar_download_button() #1298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
elnelson575
wants to merge
49
commits into
main
Choose a base branch
from
feat/toolbar-download-button
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
97016b8
Add design spec for toolbar_download_button()
elnelson575 8c14262
feat: Add toolbar_download_button() R functions
elnelson575 dd503b5
feat: Add TypeScript binding for toolbar_download_button
elnelson575 a0c9fc7
feat: Add SCSS styles for toolbar_download_button
elnelson575 9891624
test: Add tests for toolbar_download_button
elnelson575 4260dd3
`air format` (GitHub Actions)
elnelson575 c2105d8
`devtools::document()` (GitHub Actions)
elnelson575 f280ab4
Resave distributed files (GitHub Action)
elnelson575 915bc4b
Resave data (GitHub Action)
elnelson575 5ff6cce
Address PR review feedback
elnelson575 af81d20
Use custom message handler instead of InputBinding for download button
elnelson575 6865fba
feat: expand toolbarDownloadButton message handler to support label, …
elnelson575 29ddfe9
fix: correct imports, add null guards, use hasDefinedProperty in tool…
elnelson575 9048f74
fix: gate toolbar download button hover/focus behind btn-default to r…
elnelson575 a1f4de2
test: add failing tests for toolbar_download_button() enabled param
elnelson575 d42a592
feat: wrap shiny::downloadButton() and replace disabled with tristate…
elnelson575 4315c63
fix: use dev shiny downloadButton(enabled=) directly, remove post-pro…
elnelson575 116de3c
feat: expand update_toolbar_download_button() with label, icon, show_…
elnelson575 4889e6e
chore: rebuild components and regenerate docs
elnelson575 2591133
test: update toolbar_download_button() snapshots for enabled param
elnelson575 9e83859
docs: rewrite download-button demo for three enabled modes
elnelson575 b661049
fix: align with Shiny PR #4371 — rename data-ignore-update to data-sh…
elnelson575 b0181eb
feat: warn on invalid enabled values in toolbar_download_button()
elnelson575 b8b4cdb
Updated to add commented gate + tests
elnelson575 e5b45f6
chore: remove download-button design doc and autoenable demo
elnelson575 8ea8e24
feat: add toolbar_download_button with class support and fix hover st…
elnelson575 95b63b1
refactor: address PR review comments on toolbar_download_button
elnelson575 d19b45c
refactor: replace toolbar SCSS mixin with explicit shared selector block
elnelson575 70c8778
fix: align toolbar_download_button border class with toolbar_input_bu…
elnelson575 065775f
chore: commit compiled JS dist for toolbarDownloadButton.ts changes
elnelson575 162c6a4
docs: explain why action-label/action-icon wrappers are built manually
elnelson575 50b9bfa
docs: clarify LibSass comment and note download-button color override…
elnelson575 2ba24a6
refactor: simplify shared toolbar button styles to plain combined sel…
elnelson575 4f8eb18
refactor: consolidate shared toolbar button layout and interaction st…
elnelson575 7fe0fc4
fix: restore text-decoration suppression for all download button vari…
elnelson575 46d9ebd
test: toolbar test review — fix false-green, add 5 uncovered paths, t…
elnelson575 7ac2b78
docs: use @inheritParams for toolbar_download_button, expand example …
elnelson575 eef37dd
fix: guard label_text check with !is.null(label) in update functions;…
elnelson575 c6f0172
docs: remove renderUI note from enabled param — general Shiny behavio…
elnelson575 58e486f
chore: restore height comment in toolbar button block
elnelson575 741bfeb
chore: expand hover/active rules, clarify color comment in toolbar bu…
elnelson575 63aa1e0
chore: recompile CSS after rebase on main
elnelson575 7f4c636
test: clarify show_label test comment re: icon default
elnelson575 e2a889e
fix: update_toolbar_download_button() and test cleanup
elnelson575 eecaa9e
docs: inheritParams for update_toolbar_download_button
elnelson575 02457f1
`air format` (GitHub Actions)
elnelson575 0f4d60a
`devtools::document()` (GitHub Actions)
elnelson575 ad39e56
`yarn build` (GitHub Actions)
elnelson575 932ff62
Resave data (GitHub Action)
elnelson575 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.