Skip to content

make the core::ffi::va_list module private#155754

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
folkertdev:hide-core-ffi-va-list
Apr 25, 2026
Merged

make the core::ffi::va_list module private#155754
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
folkertdev:hide-core-ffi-va-list

Conversation

@folkertdev
Copy link
Copy Markdown
Contributor

@folkertdev folkertdev commented Apr 24, 2026

tracking issue: #44930

the types are exported from core::ffi itself.

T-libs-api decided that we should only export the types from core::ffi, and should not make core::ffi::va_list public, see #44930 (comment).

r? tgross35

@folkertdev
make the core::ffi::va_list module private
3851c60 
the types are exported from `core::ffi` itself
@folkertdev folkertdev added the F-c_variadic `#![feature(c_variadic)]` label Apr 24, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 24, 2026

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 24, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 24, 2026

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

tgross35
tgross35 approved these changes Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tgross35 tgross35 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with ci

View changes since this review

@tgross35
Copy link
Copy Markdown
Contributor

tgross35 commented Apr 24, 2026

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 24, 2026

📌 Commit 3851c60 has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 24, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Apr 25, 2026
@bors
Auto merge of #155755 - JonathanBrouwer:rollup-oG1Wz3V, r=JonathanBro…
597d9e4 
…uwer

Rollup of 3 pull requests

Successful merges:

 - #155754 (make the `core::ffi::va_list` module private)
 - #155522 (cmse: test returning `MaybeUninit<T>`)
 - #155741 (std: Refactor BufWriter::flush to use the `?` operator)
@rust-bors rust-bors Bot merged commit 6d6b99e into rust-lang:main Apr 25, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 25, 2026
rust-timer added a commit that referenced this pull request Apr 25, 2026
@rust-timer
Unrolled build for #155754
50bf78e 
Rollup merge of #155754 - folkertdev:hide-core-ffi-va-list, r=tgross35

make the `core::ffi::va_list` module private

tracking issue: #44930

the types are exported from `core::ffi` itself.

T-libs-api decided that we should only export the types from `core::ffi`, and should not make `core::ffi::va_list` public, see #44930 (comment).

r? tgross35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels

F-c_variadic `#![feature(c_variadic)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

3 participants

@folkertdev @rustbot @tgross35