Android: Disable setAllowFileAccess in NewsblurWebview#2110
Open
jim-daf wants to merge 1 commit into
Open
Conversation
NewsblurWebview already serves bundled assets through WebViewAssetLoader (see NewsblurWebViewClient.shouldInterceptRequest and setAssetLoader). The reading WebView is loaded with READING_BASE_URL = "https://appassets.androidplatform.net/assets/", which is the standard virtual host that WebViewAssetLoader uses to serve android_asset over https. The page never has a file:// URL in its address bar or as the main frame. setAllowFileAccess(true) is therefore not load-bearing here. Flip it to false. The asset loader pathway is unaffected because shouldInterceptRequest serves resources directly from the AssetManager and does not consult this flag. Assisted-by: Claude (Anthropic)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2109.
NewsblurWebviewalready integratesWebViewAssetLoaderfor bundled resources, andReadingItemFragmentloads articles with the httpsappassetsvirtual host:The reading WebView never loads a
file://URL as the main frame, and asset requests are served byassetLoader.shouldInterceptRequest, which reads from theAssetManagerregardless ofsetAllowFileAccess.Change
In
NewsblurWebviewconstructor, flipsetAllowFileAccess(true)tosetAllowFileAccess(false). Short inline comment recording the asset-loader rationale.The asset-loader pathway is unaffected. The change is contained to the Android client.
Assisted-by: Claude (Anthropic)