Skip to content

Android: Disable setAllowFileAccess in NewsblurWebview #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jim-daf wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Android: Disable setAllowFileAccess in NewsblurWebview #2110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion clients/android/NewsBlur/app/src/main/java/com/newsblur/web/NewsblurWebview.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,12 @@ public NewsblurWebview(Context context, AttributeSet attrs) {
getSettings().setCacheMode(WebSettings.LOAD_CACHE_ELSE_NETWORK);
getSettings().setDomStorageEnabled(true);
getSettings().setSupportZoom(true);
getSettings().setAllowFileAccess(true);
// Reading WebView is loaded with the https appassets virtual host
// (READING_BASE_URL = https://appassets.androidplatform.net/assets/)
// and serves all bundled resources through
// WebViewAssetLoader.shouldInterceptRequest. It never loads a file://
// URL, so setAllowFileAccess(true) is not load-bearing here.
getSettings().setAllowFileAccess(false);

// Remove default web search and share to accommodate the custom contextual menu
getSettings().setDisabledActionModeMenuItems(WebSettings.MENU_ITEM_WEB_SEARCH);
Expand Down