[fix] Hdf5TreeModel 'destroyed' signal can segfault for python>=3.13#4616
Open
woutdenolf wants to merge 4 commits into
Open
Conversation
woutdenolf
force-pushed
the
4605-qt-bug-qwidgetdestroyed-callback-referencing-the-qwidget-itself-can-cause-segfaults
branch
from
6442b81 to
0938617
Compare
woutdenolf
force-pushed
the
4605-qt-bug-qwidgetdestroyed-callback-referencing-the-qwidget-itself-can-cause-segfaults
branch
from
0938617 to
ba6df5e
Compare
t20100
approved these changes
Jun 15, 2026
t20100
left a comment
t20100
left a comment
Member
There was a problem hiding this comment.
Thanks for the investigations!!
woutdenolf
force-pushed
the
4605-qt-bug-qwidgetdestroyed-callback-referencing-the-qwidget-itself-can-cause-segfaults
branch
from
ba6df5e to
ddeafa4
Compare
woutdenolf
commented
Jun 15, 2026
| self._args = args | ||
| self._kwargs = kwargs | ||
|
|
||
| def __call__(self, *_, **__): |
Contributor
Author
There was a problem hiding this comment.
I was hesitating between
IgnoreArgPartialignore all arguments:__call__(self, *_, **__)NoArgPartialdo not accept any arguments:__call__(self)
Perhaps the second is a better pattern?
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<Module or Topic>: <Action> <Summary>(see contributing guidelines)PR summary
Fix segfault on
gc.collect()in the following situation, a Qt/Python object destruction and garbage collection scenario, on python 3.13 or 3.14pip install --pre "ewoksfluo[test] @ git+https://gitlab.esrf.fr/workflow/ewoksapps/ewoksfluo.git@971b8c67a6447920ac9ce8be1d6aab17e24acd8a"pytest -v -ra -W error -W ignore::DeprecationWarning:orangecanvas.utils.localization -W ignore::DeprecationWarning:orangecanvas.utils.localization.si -W ignore::DeprecationWarning:matplotlib._fontconfig_pattern -W ignore::DeprecationWarning:matplotlib._mathtext -W ignore::pydantic.warnings.PydanticDeprecatedSince20 -W "ignore:Field name \"pk\" in \"EmbeddedJsonModel\" shadows an attribute in parent \"JsonModel\":UserWarning" --pyargs ewoksfluo -k test_mesh_tasks_widgetAI Disclosure