[fix] Hdf5TreeModel 'destroyed' signal can segfault for python>=3.13

src/silx/_utils.py

@@ -37,3 +37,36 @@ def nfs_cache_refresh(dirname: str) -> None:
                 _ = entry.stat()
     except Exception:
         pass
+
+
+class IgnoreArgPartial:
+    """
+    Alternative implementation of ``functools.partial`` but the partial
+    function ignores any arguments. This was done because the signature
+    is not correct which causes PyQt to pass arguments when it shouldn't.
+
+    This class was introduced as a workaround for segfaults observed with
+    ``functools.partial`` in Qt/Python object destruction and garbage
+    collection scenarios since Python 3.13.
+
+    This is possible caused by the partial keeping a reference to the
+    callstack in which the partial funcion was created.
+    """
+
+    __slots__ = ("_func", "_args", "_kwargs")
+
+    def __init__(self, func, *args, **kwargs):
+        self._func = func
+        self._args = args
+        self._kwargs = kwargs
+
+    def __call__(self, *_, **__):
+        return self._func(*self._args, **self._kwargs)
+
+    def __repr__(self):
+        return (
+            f"{type(self).__name__}("
+            f"{self._func!r}, "
+            f"args={self._args!r}, "
+            f"kwargs={self._kwargs!r})"
+        )

src/silx/gui/dialog/AbstractDataFileDialog.py

@@ -33,7 +33,6 @@
 import sys
 import os
 import logging
-import functools
 
 import numpy
 
@@ -42,6 +41,7 @@
 from silx.gui.hdf5.Hdf5TreeModel import Hdf5TreeModel
 from . import utils
 from .FileTypeComboBox import FileTypeComboBox
+from ..._utils import IgnoreArgPartial as _Partial
 
 import fabio
 
@@ -606,10 +606,15 @@ def _init(self):
         # to access to the content of the Python object with the `destroyed`
         # signal cause the Python method was already removed with the QWidget,
         # while the QObject still exists.
+        #
         # We use a static method plus explicit references to objects to
         # release. The callback do not use any ref to self.
-        onDestroy = functools.partial(self._closeFileList, self.__openedFiles)
-        self.destroyed.connect(onDestroy)
+        #
+        # Since Python 3.13, `functools.partial` can cause the callback to
+        # still segfaults, possible because it keeps a reference to the
+        # current call stack and hence this Qt object.
+
+        self.destroyed.connect(_Partial(self._closeFileList, self.__openedFiles))
 
     @staticmethod
     def _closeFileList(fileList):

src/silx/gui/hdf5/Hdf5TreeModel.py

@@ -29,7 +29,6 @@
 
 import os
 import logging
-import functools
 from .. import qt
 from .. import icons
 from .Hdf5Node import Hdf5Node
@@ -40,6 +39,7 @@
 from ...io._sliceh5 import DatasetSlice
 from ...io.url import DataUrl
 from ..._utils import nfs_cache_refresh as _nfs_cache_refresh
+from ..._utils import IgnoreArgPartial as _Partial
 
 import h5py
 
@@ -241,10 +241,15 @@ def __init__(self, parent=None, ownFiles=True):
         # to access to the content of the Python object with the `destroyed`
         # signal cause the Python method was already removed with the QWidget,
         # while the QObject still exists.
+        #
         # We use a static method plus explicit references to objects to
         # release. The callback do not use any ref to self.
-        onDestroy = functools.partial(self._closeFileList, self.__openedFiles)
-        self.destroyed.connect(onDestroy)
+        #
+        # Since Python 3.13, `functools.partial` can cause the callback to
+        # still segfaults, possible because it keeps a reference to the
+        # current call stack and hence this Qt object.
+
+        self.destroyed.connect(_Partial(self._closeFileList, self.__openedFiles))
 
     @staticmethod
     def _closeFileList(fileList):