make ConstrainedOutputModel compatible with nnvision.utility.measures:model_predictions#14
Open
MaxFBurg wants to merge 2 commits into
Open
make ConstrainedOutputModel compatible with nnvision.utility.measures:model_predictions#14MaxFBurg wants to merge 2 commits into
MaxFBurg wants to merge 2 commits into
Conversation
update to use Konsti's MEIs
Member
Author
|
Code example to reproduce the issue: |
Member
Author
|
Hi @KonstantinWilleke @PPierzc I just ran into this problem again, realizing that this PR was never reviewed. Could you please review and merge it? |
Member
Author
|
... this one would actually be important to be merged soon, as my follow up PR's might lead to merge conflicts that we could avoid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, calling model_predicitons to get the predictions of a ConstrainedOutputModel resulted in a bug, as
data_keywas inself.forward_kwargsbut also inkwargs