Skip to content

fix(fe): revert signup button to modal#3550

Merged
ojongii merged 3 commits intomainfrom
t2683-revert-signup-button-to-modal
May 5, 2026
Merged

fix(fe): revert signup button to modal#3550
ojongii merged 3 commits intomainfrom
t2683-revert-signup-button-to-modal

Conversation

@ojongii
Copy link
Copy Markdown
Contributor

@ojongii ojongii commented May 5, 2026

Description

Sign Up 버튼 클릭 시 /signup 페이지로 이동하는 대신 기존 방식대로 모달이 열리도록 변경했습니다. 새 회원가입 페이지는 라우트를 변경하는 대신 /signup 경로를 그대로 유지했어요.

Additional context

closes TAS-2683


Before submitting the PR, please make sure you do the following

@ojongii ojongii requested a review from dayeoni May 5, 2026 05:55
@ojongii ojongii self-assigned this May 5, 2026
@ojongii ojongii added ⛳️ team-frontend preview 이 라벨이 붙어있어야 프론트엔드 Preview 환경이 생성됩니다 labels May 5, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the HeaderAuthPanel component to consolidate authentication triggers within a single Dialog component. I have identified three areas for improvement: the Dialog's onOpenChange handler needs to be updated to prevent conflicts with trigger clicks, the DialogTitle requires a descriptive label and should use sr-only for accessibility instead of hidden, and the visibility change for the Sign Up button on mobile devices should be reconsidered to ensure authentication options remain accessible.

Comment thread apps/frontend/components/auth/HeaderAuthPanel.tsx Outdated
Comment thread apps/frontend/components/auth/HeaderAuthPanel.tsx
Comment thread apps/frontend/components/auth/HeaderAuthPanel.tsx
@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented May 5, 2026

Syncing Preview App Succeeded

Application: frontend
Revision: d2664406728febbbe953d89ca2438b218f469cdf
Health Status: Healthy

Open Preview | View in Argo CD

Copy link
Copy Markdown
Contributor

@dayeoni dayeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네! 고생하셨습니다~~👍

@ojongii ojongii enabled auto-merge May 5, 2026 08:33
@ojongii ojongii added this pull request to the merge queue May 5, 2026
@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented May 5, 2026

Syncing Preview App Succeeded

Application: frontend
Revision: b169bad0c3788cf7c5ad454742014bf6d5ccc224
Health Status: Healthy

Open Preview | View in Argo CD

Merged via the queue into main with commit 976595f May 5, 2026
14 checks passed
@ojongii ojongii deleted the t2683-revert-signup-button-to-modal branch May 5, 2026 08:38
@skkuding-bot skkuding-bot Bot removed the preview 이 라벨이 붙어있어야 프론트엔드 Preview 환경이 생성됩니다 label May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants