Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the HeaderAuthPanel component to consolidate authentication triggers within a single Dialog component. I have identified three areas for improvement: the Dialog's onOpenChange handler needs to be updated to prevent conflicts with trigger clicks, the DialogTitle requires a descriptive label and should use sr-only for accessibility instead of hidden, and the visibility change for the Sign Up button on mobile devices should be reconsidered to ensure authentication options remain accessible.
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
Description
Sign Up 버튼 클릭 시 /signup 페이지로 이동하는 대신 기존 방식대로 모달이 열리도록 변경했습니다. 새 회원가입 페이지는 라우트를 변경하는 대신 /signup 경로를 그대로 유지했어요.
Additional context
closes TAS-2683
Before submitting the PR, please make sure you do the following
fixes #123).