Skip to content

fix(fe): revert signup button to modal #3550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ojongii merged 3 commits into from
May 5, 2026
Merged

fix(fe): revert signup button to modal #3550

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d266440
fix(fe): revert signup button to modal
ojongii May 5, 2026
e9ab661
fix(fe): revert signup button to modal
ojongii May 5, 2026
b169bad
fix(fe): revert signup button to modal
ojongii May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 32 additions & 35 deletions apps/frontend/components/auth/HeaderAuthPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ import { useAuthModalStore } from '@/stores/authModal'
import type { Course } from '@/types/type'
import { ContestRole, type UserContest } from '@generated/graphql'
import { ChevronDown } from 'lucide-react'
import type { Route } from 'next'
import type { Session } from 'next-auth'
import Link from 'next/link'
import { usePathname } from 'next/navigation'
import { useEffect, useState } from 'react'
import { BiSolidUser } from 'react-icons/bi'
Expand Down Expand Up @@ -179,47 +177,46 @@ export function HeaderAuthPanel({
</Dialog>
</>
) : (
<>
<Dialog open={currentModal !== ''} onOpenChange={hideModal}>
<DialogTrigger asChild>
<Button
onClick={() => showSignIn()}
variant={'outline'}
className={cn(
'border-primary text-primary mr-3 hidden bg-transparent px-5 py-1 text-sm font-semibold hover:bg-[#EAF3FF] active:bg-[#D7E5FE] lg:block',
isEditor &&
'h-8 border-none bg-[#EAF3FF] text-[11px] hover:bg-[#D7E5FE]'
)}
>
Log In
</Button>
</DialogTrigger>
<DialogContent
onOpenAutoFocus={(e) => {
e.preventDefault()
}}
onInteractOutside={(e) => {
e.preventDefault()
}}
className="!h-[620px] !w-[380px] rounded-[10px]"
<Dialog open={currentModal !== ''} onOpenChange={hideModal}>
Comment thread
ojongii marked this conversation as resolved.
Outdated
<DialogTrigger asChild>
<Button
onClick={() => showSignIn()}
variant={'outline'}
className={cn(
'border-primary text-primary mr-3 hidden bg-transparent px-5 py-1 text-sm font-semibold hover:bg-[#EAF3FF] active:bg-[#D7E5FE] lg:block',
isEditor &&
'h-8 border-none bg-[#EAF3FF] text-[11px] hover:bg-[#D7E5FE]'
)}
>
<DialogHeader className="hidden">
<DialogTitle />
</DialogHeader>
<AuthModal />
</DialogContent>
</Dialog>
<Link href={'/signup' as Route}>
Log In
</Button>
</DialogTrigger>
<DialogContent
onOpenAutoFocus={(e) => {
e.preventDefault()
}}
onInteractOutside={(e) => {
e.preventDefault()
}}
className="!h-[620px] !w-[380px] rounded-[10px]"
>
<DialogHeader className="hidden">
<DialogTitle />
</DialogHeader>
Comment thread
ojongii marked this conversation as resolved.
<AuthModal />
</DialogContent>
<DialogTrigger asChild>
<Button
onClick={() => showSignUp()}
className={cn(
'px-5 py-1 text-sm font-semibold',
'hidden px-5 py-1 text-sm font-semibold lg:block',
Comment thread
ojongii marked this conversation as resolved.
isEditor && 'h-8 text-[11px]'
)}
>
Sign Up
</Button>
</Link>
</>
</DialogTrigger>
</Dialog>
)}
</div>
)
Expand Down
Loading