Fix - tablereport plots fail when dataframe contains $$ as values #2154
Merged
rcap107 merged 9 commits intoJun 16, 2026
Conversation
…parse_math` : False for mathematical expressions in _MATPLOTLIB_RC_PARAMS = {
MarieSacksick
added
the
CFM sprint June 2026
rcap107
changed the title
emassoulie
reviewed
Jun 10, 2026
| contains an inner transformer that has a ``score`` method has been fixed. | ||
| :pr:`2052` by :user:`Jérôme Dockès <jeromedockes>`. | ||
| An error that could arise when generating the frame with reports may fail when text is containing $$ has been fixed. | ||
| :pr:`2097` by :user:`Katerina Michenina <Michenina-Lab>`, :user: `<CecilyTS>`, :user: `Eve Rabin <eve2705>`. |
Contributor
There was a problem hiding this comment.
2097 is the issue number, not the PR number! This is PR 2154 (cf. URL)
emassoulie
reviewed
Jun 11, 2026
| - An error that could arise when calling ``score`` on a ``SkrubLearner`` that | ||
| contains an inner transformer that has a ``score`` method has been fixed. | ||
| :pr:`2052` by :user:`Jérôme Dockès <jeromedockes>`. | ||
| An error that could arise when generating the frame with reports may fail when text is containing $$ has been fixed. |
Contributor
There was a problem hiding this comment.
Suggested change
| An error that could arise when generating the frame with reports may fail when text is containing $$ has been fixed. | |
| An error that could arise when running `TableReport` on dataframes containing | |
| double dollar (`$$`) signs has been fixed. |
Member
|
Hi @Michenina-Lab, as we discussed in the issue this should merge upstream after #2159 is merged and the minimum matplotlib version becomes 3.6. That should let the tests pass. |
rcap107
reviewed
Jun 15, 2026
Member
There was a problem hiding this comment.
Could you move the test case in in skrub/_reporting/tests/test_summarize.py?
something like this would work:
def test_dollar_sign(df_module):
df = df_module.make_dataframe(
{
"text": [
"hello world",
"foo bar",
"this is not latex $$ just a double dollar sign",
]
}
)
summarize_dataframe(df, with_plots=True, title=None, verbose=0)df_module is needed to make sure that the the tests run with both pandas and polars
then this file can be removed
jeromedockes
approved these changes
Jun 16, 2026
jeromedockes
left a comment
jeromedockes
left a comment
Member
There was a problem hiding this comment.
thank you @Michenina-Lab !
Contributor
Author
Big thanks for your help and guidance, @jeromedockes, @rcap107, @emassoulie ! |
Member
|
Thank you @Michenina-Lab! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix Pull Request
Description
An error that could arise when generating the frame with reports may fail when text is containing $$ has been fixed.fixes #2097
Checklist
How Has This Been Tested?
Tested using test_summarize_dataframe.py