Skip to content

Fix - tablereport plots fail when dataframe contains $$ as values #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcap107 merged 9 commits into from
Jun 16, 2026
+19 −2
Merged

Fix - tablereport plots fail when dataframe contains $$ as values #2154

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d596667
-- Fixed issue 2097 summarize_dataframe from _plotting.py with `text…
Michenina-Lab Jun 10, 2026
807b053
-- Logged code updates for :pr:`#2097` in ``CHANGES.rst``
Michenina-Lab Jun 10, 2026
14a7e79
-- Logged code updates for :pr:`#2097` in ``CHANGES.rst``
Michenina-Lab Jun 10, 2026
8c82e8b
-- Cleaned errors in CHANGES.rst and added test_summarize_dataframe.py
Michenina-Lab Jun 12, 2026
5d6d0fa
-- Cleaned CHANGES.rst log
Michenina-Lab Jun 12, 2026
99ee11b
Merge remote-tracking branch 'upstream/main' into first_Probabl_hacka…
Michenina-Lab Jun 12, 2026
d06c732
-- Logged code updates for :pr:`#2097` in ``CHANGES.rst``
Michenina-Lab Jun 13, 2026
5bb72fb
add test and remove extra file
jeromedockes Jun 16, 2026
1821316
fix changelog
jeromedockes Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,11 @@ Bugfixes
- An error that could arise when calling ``score`` on a ``SkrubLearner`` that
contains an inner transformer that has a ``score`` method has been fixed.
:pr:`2052` by :user:`Jérôme Dockès <jeromedockes>`.
- An error that could arise when running `TableReport` on dataframes containing
double dollar (`$$`) signs has been fixed.
:pr:`2154` by :user:`Katerina Michenina <Michenina-Lab>,
:user: `<CecilyTS>`,
:user: `Eve Rabin <eve2705>`.

Deprecations
------------
Expand Down
1 change: 1 addition & 0 deletions skrub/_reporting/_plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
"boxplot.flierprops.color": _TEXT_COLOR_PLACEHOLDER,
"boxplot.flierprops.markeredgecolor": _TEXT_COLOR_PLACEHOLDER,
"boxplot.whiskerprops.color": _TEXT_COLOR_PLACEHOLDER,
"text.parse_math": False,
}


Expand Down
23 changes: 23 additions & 0 deletions skrub/tests/test_summarize_dataframe.py
View file
Open in desktop

@rcap107 rcap107 Jun 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the test case in in skrub/_reporting/tests/test_summarize.py?

something like this would work:

def test_dollar_sign(df_module):
    df = df_module.make_dataframe(
        {
            "text": [
                "hello world",
                "foo bar",
                "this is not latex $$ just a double dollar sign",
            ]
        }
    )
    summarize_dataframe(df, with_plots=True, title=None, verbose=0)

df_module is needed to make sure that the the tests run with both pandas and polars

then this file can be removed

Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
"""Minimal reproducer: does skrub crash on string columns containing '$$'?
Run with:
uv run repro_skrub_dollar_sign.py
"""

import pandas as pd

from skrub._reporting._summarize import summarize_dataframe

df = pd.DataFrame(
{
"text": [
"hello world",
"foo bar",
"this is not latex $$ just a double dolar sign",
]
}
)
try:
summarize_dataframe(df, with_plots=True, title=None, verbose=0)
print("PASS: no error")
except ValueError as e:
print(f"FAIL: {e}")
Loading