Implement event duplication feature and improve registration error handling#407
Closed
Ethan-Stone1 wants to merge 79 commits intosnap-cloud:mainfrom
Closed
Implement event duplication feature and improve registration error handling#407Ethan-Stone1 wants to merge 79 commits intosnap-cloud:mainfrom
Ethan-Stone1 wants to merge 79 commits intosnap-cloud:mainfrom
Conversation
Tests exercise icalendar_proposals with nil event_type, nil time, and nil room — all of which currently raise NoMethodError.
Skip events with nil time or event_type in icalendar_proposals, and use safe navigation for room name to avoid NoMethodError when generating .ics calendar exports.
The sign-up form silently fails when validation errors occur (e.g., duplicate username, password too short, password mismatch) because the Devise registration views never render resource.errors. Add error message rendering to the _form_fields partial so users see clear feedback when registration fails. Fixes #61
Fix registration form not displaying validation errors
Implement a new feature (Issue #54) to duplicate events within a conference
Contributor
Author
…ment-notification-toggle Made-with: Cursor # Conflicts: # db/schema.rb
…ion-toggle Feature/organizer comment notification toggle
Fix ical nil event data
Add dynamic variable substitution to conference descriptions
Hide code of conduct link when none is set
Remove organization grouping from conference menu
Tentative accept
Move conference dates to 2026-10-14/16 so before_end_of_conference passes. Expand all abstracts past 100 words to satisfy abstract_limit. Confirm tracks via update_column after create since the AASM confirm transition requires a submitter; valid_track checks track.confirmed?. Replace exists? skip with destroy! so re-runs always produce a fresh seed.
* Force SSO for new sign-ups via environment variable Add PREVENT_NEW_LOCAL_PASSWORDS env var that hides the local registration form and shows only Google and Snap! SSO buttons. Existing users can still sign in with username/password below the SSO buttons. Local auth code is preserved to avoid upstream merge conflicts. * Use button_to for SSO buttons to ensure POST without JS dependency
Member
|
This is from main to main -- going to close this so we can merge smaller PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements Issue cs169#54 to allow for the duplication of events. Additionally implements a small fix to registration form not displaying validation errors
Event Duplication:
On the event page there is now a "Duplicate" button
Pressing the button opens a popup where you can select how many different duplicates of the event you would like
The duplicated events have all the same data as the original (minus the ID and the creator is the person who clicked duplicate)
How should this PR be tested?
There are a ton of tests (in fact most of the lines of code I added are tests. To run them type
bundle exec rspec spec/features/event_duplication_spec.rb spec/controllers/admin/events_controller_spec.rb
in the terminal.
Are there any complications to deploying this?
No data migrations or anything complicated about deploying.