Implement event duplication feature and improve registration error handling

.rubocop_todo.yml

@@ -495,6 +495,8 @@ RSpec/SubjectStub:
 RSpec/VerifiedDoubles:
   Exclude:
     - 'spec/datatables/user_datatable_spec.rb'
+    - 'spec/features/ticket_purchases_spec.rb'
+    - 'spec/models/payment_spec.rb'
     - 'spec/pdfs/ticket_pdf_spec.rb'
 
 # Offense count: 1

.ruby-version

@@ -1 +1 @@
-3.3.8
+3.3.10

.tool-versions

@@ -1,2 +1,2 @@
-ruby 3.3.8
+ruby 3.3.10
 nodejs 16.20.2

Gemfile

@@ -38,7 +38,7 @@ gem 'cloudinary'
 # for internationalizing
 gem 'rails-i18n'
 # Windows: timezone data (required on Windows for tzinfo)
-gem 'tzinfo-data', platforms: %i[ windows jruby ]
+gem 'tzinfo-data', platforms: %i[windows jruby]
 
 # as authentification framework
 gem 'devise'

Gemfile.lock

@@ -254,6 +254,7 @@ GEM
       faraday (~> 2.0)
     fastimage (2.3.0)
     feature (1.4.0)
+    ffi (1.17.0-arm64-darwin)
     ffi (1.17.0-x64-mingw-ucrt)
     ffi (1.17.0-x86_64-linux-gnu)
     font-awesome-sass (6.5.1)
@@ -383,6 +384,8 @@ GEM
     next_rails (1.3.0)
       colorize (>= 0.8.1)
     nio4r (2.7.0)
+    nokogiri (1.16.6-arm64-darwin)
+      racc (~> 1.4)
     nokogiri (1.16.6-x64-mingw-ucrt)
       racc (~> 1.4)
     nokogiri (1.16.6-x86_64-linux)
@@ -641,6 +644,7 @@ GEM
       actionpack (>= 5.2)
       activesupport (>= 5.2)
       sprockets (>= 3.0.0)
+    sqlite3 (1.7.2-arm64-darwin)
     sqlite3 (1.7.2-x64-mingw-ucrt)
     sqlite3 (1.7.2-x86_64-linux)
     ssrf_filter (1.1.2)
@@ -668,7 +672,7 @@ GEM
     turbolinks-source (5.2.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    tzinfo-data (1.2025.3)
+    tzinfo-data (1.2026.1)
       tzinfo (>= 1.0.0)
     uglifier (4.2.0)
       execjs (>= 0.3.0, < 3)
@@ -705,6 +709,7 @@ GEM
     zeitwerk (2.6.13)
 
 PLATFORMS
+  arm64-darwin-25
   x64-mingw-ucrt
   x86_64-linux
 

app/assets/javascripts/osem-switch.js

@@ -1,15 +1,61 @@
 function checkboxSwitch(selector){
   $(selector).bootstrapSwitch();
 
-  $(selector).on('switchChange.bootstrapSwitch', function(event, state) {
-    var url = $(this).attr('url') + state;
-    var method = $(this).attr('method') || 'patch';
+  // Prevent duplicated event handlers when the page is re-rendered.
+  $(selector).off('switchChange.bootstrapSwitch');
+  $(selector).off('.osemSwitchGuard');
 
-    $.ajax({
-      url: url,
-      type: method,
-      dataType: 'script'
-    });
+  // Mark as user-initiated before bootstrapSwitch triggers switchChange.
+  // Important: bootstrapSwitch often binds clicks on its generated wrapper/label,
+  // so we must listen on those too (not only on the hidden checkbox input).
+  $(selector).each(function() {
+    var $input = $(this);
+    $input.data('osem-user-toggle', false);
+
+    var $wrapper = $input.closest('.bootstrap-switch');
+    if ($wrapper.length === 0) {
+      $wrapper = $input.parent();
+    }
+
+    $wrapper.off('click.osemSwitchGuard mouseup.osemSwitchGuard touchend.osemSwitchGuard pointerup.osemSwitchGuard');
+    $wrapper.on(
+      'click.osemSwitchGuard mouseup.osemSwitchGuard touchend.osemSwitchGuard pointerup.osemSwitchGuard',
+      function() {
+        $input.data('osem-user-toggle', true);
+      }
+    );
+  });
+
+  $(selector).on('switchChange.bootstrapSwitch', function(_event, state) {
+    var $el = $(this);
+    if (!$el.data('osem-user-toggle')) {
+      return;
+    }
+
+    // bootstrapSwitch can emit multiple switchChange events per user click.
+    // Delay the request slightly, then read the final checkbox state to send once.
+    var existingTimer = $el.data('osem-user-toggle-timer');
+    if (existingTimer) {
+      clearTimeout(existingTimer);
+    }
+
+    var method = $el.attr('method') || 'patch';
+    var urlBase = $el.attr('url');
+
+    var timer = setTimeout(function() {
+      $el.data('osem-user-toggle', false);
+
+      var checked = $el.is(':checked');
+      var url = urlBase + (checked ? 'true' : 'false');
+
+      $.ajax({
+        url: url,
+        type: method,
+        dataType: 'script'
+      });
+    }, 180);
+
+    $el.data('osem-user-toggle-timer', timer);
   });
 }
 

app/assets/stylesheets/osem-payments.scss

@@ -1,3 +1,6 @@
-.stripe-button-el {
-  float: right;
+.payment-actions {
+  margin-top: 15px;
+  display: flex;
+  justify-content: space-between;
+  align-items: center;
 }

app/controllers/admin/conferences_controller.rb

@@ -67,19 +67,62 @@ def index
     end
 
     def new
-      @conference = Conference.new
+      if params[:duplicate_from].present?
+        source = Conference.find_by(short_title: params[:duplicate_from])
+        if source && can?(:read, source)
+          @conference = Conference.new(
+            description:        source.description,
+            timezone:           source.timezone,
+            start_hour:         source.start_hour,
+            end_hour:           source.end_hour,
+            color:              source.color,
+            custom_css:         source.custom_css,
+            ticket_layout:      source.ticket_layout,
+            registration_limit: source.registration_limit,
+            booth_limit:        source.booth_limit,
+            organization_id:    source.organization_id
+          )
+          @duplicate_from_source = source.short_title
+        else
+          @conference = Conference.new
+        end
+      else
+        @conference = Conference.new
+      end
     end
 
     def create
       @conference = Conference.new(conference_params)
 
+      if params[:duplicate_from].present?
+        source = Conference.find_by(short_title: params[:duplicate_from])
+        if source && can?(:read, source)
+          @conference.assign_attributes(
+            description:        source.description,
+            custom_css:         source.custom_css,
+            ticket_layout:      source.ticket_layout,
+            registration_limit: source.registration_limit,
+            booth_limit:        source.booth_limit,
+            color:              source.color,
+            start_hour:         source.start_hour,
+            end_hour:           source.end_hour
+          )
+        end
+      end
+
       if @conference.save
         # user that creates the conference becomes organizer of that conference
         current_user.add_role :organizer, @conference
 
+        if params[:duplicate_from].present?
+          source = Conference.find_by(short_title: params[:duplicate_from])
+          @conference.copy_associations_from(source) if source && can?(:read, source)
+        end
+
         redirect_to admin_conference_path(id: @conference.short_title),
                     notice: 'Conference was successfully created.'
       else
+        @duplicate_from_source = params[:duplicate_from]
         flash.now[:error] = 'Could not create conference. ' + @conference.errors.full_messages.to_sentence
         render action: 'new'
       end

app/controllers/admin/emails_controller.rb

@@ -28,11 +28,11 @@ def index
 
     def email_params
       params.require(:email_settings).permit(:send_on_registration,
-                                             :send_on_accepted, :send_on_rejected, :send_on_confirmed_without_registration,
+                                             :send_on_accepted, :send_on_tentative_accepted, :send_on_rejected, :send_on_confirmed_without_registration,
                                              :send_on_submitted_proposal,
                                              :submitted_proposal_subject, :submitted_proposal_body,
-                                             :registration_subject, :accepted_subject, :rejected_subject, :confirmed_without_registration_subject,
-                                             :registration_body, :accepted_body, :rejected_body, :confirmed_without_registration_body,
+                                             :registration_subject, :accepted_subject, :tentative_accepted_subject, :rejected_subject, :confirmed_without_registration_subject,
+                                             :registration_body, :accepted_body, :tentative_accepted_body, :rejected_body, :confirmed_without_registration_body,
                                              :send_on_conference_dates_updated, :conference_dates_updated_subject, :conference_dates_updated_body,
                                              :send_on_conference_registration_dates_updated, :conference_registration_dates_updated_subject, :conference_registration_dates_updated_body,
                                              :send_on_venue_updated, :venue_updated_subject, :venue_updated_body,

app/controllers/admin/events_controller.rb

@@ -115,6 +115,46 @@ def new
       @superevents = @program.events.where(superevent: true)
     end
 
+    def preview_tentative_accept
+      email_settings = @conference.email_settings
+      @tentative_subject = email_settings.tentative_accepted_subject.presence
+      default_body = email_settings.tentative_accepted_body.presence
+      @missing_committee_review = @event.committee_review.blank?
+      @tentative_body = EmailTemplateParser.parse_template(default_body, email_settings.get_values(@conference, @event.submitter, @event)) unless @missing_committee_review
+      render :tentative_accept
+    end
+
+    def tentative_accept
+      email_settings = @conference.email_settings
+
+      if @event.committee_review.blank?
+        flash.now[:alert] = 'Committee feedback is required before sending a tentative acceptance email.'
+        @tentative_subject = email_settings.tentative_accepted_subject.presence
+        email_settings.tentative_accepted_body.presence
+        @missing_committee_review = true
+        render :tentative_accept and return
+      end
+
+      @tentative_subject = email_settings.tentative_accepted_subject.presence
+      default_body = email_settings.tentative_accepted_body.presence
+      @missing_committee_review = false
+      @tentative_body = EmailTemplateParser.parse_template(default_body, email_settings.get_values(@conference, @event.submitter, @event))
+      send_mail = email_settings.send_on_tentative_accepted
+
+      begin
+        @event.tentatively_accept(send_mail: send_mail, subject: @tentative_subject, body: @tentative_body)
+        @event.save!
+        flash[:notice] = 'Event tentatively accepted!'
+        redirect_to admin_conference_program_events_path(conference_id: @conference.short_title) and return
+      rescue ActiveRecord::RecordInvalid => e
+        flash.now[:error] = "Could not save tentative acceptance: #{e.record.errors.full_messages.join(', ')}"
+        render :tentative_accept
+      rescue Transitions::InvalidTransition => e
+        flash.now[:error] = "Update state failed. #{e.message}"
+        render :tentative_accept
+      end
+    end
+
     def accept
       send_mail = @event.program.conference.email_settings.send_on_accepted
       subject = @event.program.conference.email_settings.accepted_subject.blank?
@@ -182,6 +222,30 @@ def toggle_attendance
       end
     end
 
+    def duplicate
+      count = params[:count].to_i # Invalid input will be treated as 0, which will be caught by validation below
+
+      # Validate count
+      unless count.between?(1, 100)
+        flash[:alert] = 'Invalid number of duplicates. Please enter a number between 1 and 100.'
+        redirect_to admin_conference_program_event_path(@conference.short_title, @event)
+        return
+      end
+
+      duplicator = EventDuplicator.new(@event, current_user)
+      duplicated_events = duplicator.duplicate(count)
+
+      flash[:notice] = if duplicated_events.length == 1
+                         "Event '#{duplicated_events.first.title}' duplicated successfully."
+                       else
+                         "#{duplicated_events.length} copies of '#{@event.title}' created successfully."
+                       end
+      redirect_to admin_conference_program_events_path(@conference.short_title)
+    rescue StandardError
+      flash[:alert] = 'Could not duplicate event'
+      redirect_to admin_conference_program_event_path(@conference.short_title, @event)
+    end
+
     def destroy
       @event = Event.find(params[:id])
       if @event.destroy

app/controllers/admin/roles_controller.rb

@@ -6,7 +6,7 @@ class RolesController < Admin::BaseController
     before_action :set_selection
     authorize_resource :role, except: :index
     # Show flash message with ajax calls
-    after_action :prepare_unobtrusive_flash, only: :toggle_user
+    after_action :prepare_unobtrusive_flash, only: %i[toggle_user toggle_comment_notifications]
 
     def index
       @roles = Role.where(resource: @conference)
@@ -21,7 +21,11 @@ def show
              else
                toggle_user_admin_conference_role_path(@conference.short_title, @role.name)
              end
-      @users = @role.users
+      @users_roles = UsersRole.where(role: @role).includes(:user)
+      @comment_notifications_url =
+        if @track.nil?
+          toggle_comment_notifications_admin_conference_role_path(@conference.short_title, @role.name)
+        end
     end
 
     def edit
@@ -103,6 +107,30 @@ def toggle_user
       end
     end
 
+    def toggle_comment_notifications
+      user = User.find_by(email: user_params[:email])
+      state = user_params[:state]
+
+      redirect_url = admin_conference_role_path(@conference.short_title, @role.name)
+      unless user
+        redirect_to redirect_url, error: 'Could not find user. Please provide a valid email!' and return
+      end
+
+      users_role = UsersRole.find_by(user: user, role: @role)
+      unless users_role
+        redirect_to redirect_url, error: 'Could not find organizer setting for this user.' and return
+      end
+
+      # Be tolerant to different representations coming from the client (e.g. "true", "1", true).
+      email_notifications = ActiveModel::Type::Boolean.new.cast(state)
+      users_role.update!(email_notifications: email_notifications)
+
+      respond_to do |format|
+        format.js
+        format.html { redirect_to redirect_url, notice: 'Successfully updated notification setting.' }
+      end
+    end
+
     protected
 
     def set_selection