Fix Micron NVMe disk health output showing N/A#694
Open
gauravnagesh-msft wants to merge 1 commit into
Open
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ashwnsri
previously approved these changes
Jun 15, 2026
vvolam
reviewed
Jun 15, 2026
Contributor
|
@gauravnagesh-msft This https://github.com/sonic-net/sonic-host-services/pull/386/changes might help to fix PR pipeline issue. Please see if similar fix is needed here? |
Author
|
/azpw run |
Collaborator
|
Retrying failed(or canceled) jobs... |
Collaborator
|
Retrying failed(or canceled) stages in build 1139399: ✅Stage __default: |
Signed-off-by: gauravnagesh-msft <274629584+gauravnagesh-msft@users.noreply.github.com>
562c2e0 to
070b230
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vvolam
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding
Micronto the list of NVMe SSD vendors that skip vendor-specific parsing infetch_parse_info()For Micron NVMe SSDs, the generic NVMe parserparse_nvme_ssd_infoalready correctly extracts the health value from the smartctlPercentage Usedfield. However, the code then proceeds to callparse_micron_info()which attempts to parse SATA-specific attributes(Percent_Lifetime_Used / Percent_Lifetime_Remain)that don't exist in NVMe output, overwriting the valid health value with N/A.This fix adds Micron to the early-return guard (alongside the already-handled Virtium and ATP vendors) so that the vendor-specific parser is skipped for Micron NVMe devices.
Motivation and Context
On platforms using Micron NVMe SSDs,
show platform ssdhealthincorrectly returns N/A even though smartctl provides valid health data. The root cause is that parse_micron_info() is designed for SATA drives and looks for SATA SMART attributes that are absent in NVMe output, causing it to overwrite the correct health value that was already parsed by parse_nvme_ssd_info().How Has This Been Tested?
Tested on platforms using Micron NVMe SSD disks
Before changes :
After changes :
Additional Information (Optional)